Resolution of https://bugs.webkit.org/show_bug.cgi?id=56691 caused regression for synchronous requests.
Created attachment 86671 [details] Patch
Attachment 86671 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/platform/chromium/test_expectations.txt:668: Path does not exist. http/tests/inspector/network/network-size-sync.html [test/expectations] [2] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 86673 [details] Patch with test
Created attachment 86674 [details] Patch with fixed test
Comment on attachment 86674 [details] Patch with fixed test View in context: https://bugs.webkit.org/attachment.cgi?id=86674&action=review > LayoutTests/platform/chromium/test_expectations.txt:668 > +BUG_VSEVIK SKIP : http/tests/inspector/network/network-size-sync.html = FAIL This new test is skipped on all platform so what's the point in adding it?
Comment on attachment 86674 [details] Patch with fixed test View in context: https://bugs.webkit.org/attachment.cgi?id=86674&action=review >> LayoutTests/platform/chromium/test_expectations.txt:668 >> +BUG_VSEVIK SKIP : http/tests/inspector/network/network-size-sync.html = FAIL > > This new test is skipped on all platform so what's the point in adding it? It will be enabled once this works in at least one port. The patch for chromium port will follow soon.
Comment on attachment 86674 [details] Patch with fixed test Rejecting attachment 86674 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2 Last 500 characters of output: bCore/loader/FrameLoader.cpp Hunk #1 succeeded at 1543 (offset 4 lines). Hunk #2 succeeded at 1960 (offset 4 lines). Hunk #3 succeeded at 2816 (offset 6 lines). Hunk #4 succeeded at 3109 (offset 6 lines). patching file Source/WebCore/loader/ResourceLoadNotifier.cpp Hunk #1 succeeded at 152 (offset -2 lines). patching file Source/WebCore/loader/ResourceLoadNotifier.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Pavel Feldman', u'--fo..." exit_code: 1 Full output: http://queues.webkit.org/results/8233649
Created attachment 86805 [details] Patch with merge conflicts fixes
Comment on attachment 86805 [details] Patch with merge conflicts fixes Clearing flags on attachment: 86805 Committed r81897: <http://trac.webkit.org/changeset/81897>
All reviewed patches have been landed. Closing bug.