Bug 56950 – Fix ambiguous method call in V8 IDL generated code for DOMStringList callback parameter

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tyler Close]

Fix ambiguous method call in V8 IDL generated code for DOMStringList callback parameter

[Tyler Close]

Created attachment 86669 [details]
Patch

[WebKit Review Bot]

Attachment 86669 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:130:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jeremy Orlow]

Comment on attachment 86669 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 86669 [details]
Patch

Clearing flags on attachment: 86669

Committed r81799: <http://trac.webkit.org/changeset/81799>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Nate Chapin]

Is there a reason it's necessary to use a PassRefPtr<DOMStringList> in these cases, rather than a raw DOMStringList* ?

Sorry for not asking before the patch landed.

[Tyler Close]

@japhet: I tried using the raw type DOMStringList* first. As I recall, there were a couple problems with that: v8ValueToWebCoreDOMStringList() returns a PassRefPtr, so you get another compile error in the IDL stubs. It also caused problems for some of the hand-written IDB stubs.

[Nate Chapin]

(In reply to comment #7)
> @japhet: I tried using the raw type DOMStringList* first. As I recall, there were a couple problems with that: v8ValueToWebCoreDOMStringList() returns a PassRefPtr, so you get another compile error in the IDL stubs. It also caused problems for some of the hand-written IDB stubs.

Ok, sounds good.  Just figured I should ask, since I didn't know how DOMStringList is used well enough to have known about the v8ValueToWebCoreDOMStringList issue.