Bug 56950 - Fix ambiguous method call in V8 IDL generated code for DOMStringList callback parameter
Summary: Fix ambiguous method call in V8 IDL generated code for DOMStringList callback...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-23 12:31 PDT by Tyler Close
Modified: 2011-03-24 13:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (12.46 KB, patch)
2011-03-23 12:33 PDT, Tyler Close 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Close 2011-03-23 12:31:31 PDT 
Fix ambiguous method call in V8 IDL generated code for DOMStringList callback parameter
Comment 1 Tyler Close 2011-03-23 12:33:10 PDT 
Created attachment 86669 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-23 12:36:17 PDT 
Attachment 86669 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:130:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jeremy Orlow 2011-03-23 12:38:30 PDT 
Comment on attachment 86669 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2011-03-23 13:13:38 PDT 
Comment on attachment 86669 [details]
Patch

Clearing flags on attachment: 86669

Committed r81799: <http://trac.webkit.org/changeset/81799>
Comment 5 WebKit Commit Bot 2011-03-23 13:13:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Nate Chapin 2011-03-24 13:00:15 PDT 
Is there a reason it's necessary to use a PassRefPtr<DOMStringList> in these cases, rather than a raw DOMStringList* ?

Sorry for not asking before the patch landed.
Comment 7 Tyler Close 2011-03-24 13:18:47 PDT 
@japhet: I tried using the raw type DOMStringList* first. As I recall, there were a couple problems with that: v8ValueToWebCoreDOMStringList() returns a PassRefPtr, so you get another compile error in the IDL stubs. It also caused problems for some of the hand-written IDB stubs.
Comment 8 Nate Chapin 2011-03-24 13:20:58 PDT 
(In reply to comment #7)
> @japhet: I tried using the raw type DOMStringList* first. As I recall, there were a couple problems with that: v8ValueToWebCoreDOMStringList() returns a PassRefPtr, so you get another compile error in the IDL stubs. It also caused problems for some of the hand-written IDB stubs.

Ok, sounds good.  Just figured I should ask, since I didn't know how DOMStringList is used well enough to have known about the v8ValueToWebCoreDOMStringList issue.