Bug 56943 - CSS3 nth-child(n) selector fails
Summary: CSS3 nth-child(n) selector fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL: http://tools.css3.info/selectors-test...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-23 11:41 PDT by Ian Ellison-Taylor
Modified: 2011-05-01 10:08 PDT (History)
4 users (show)

See Also:

Attachments
nth-child(n) test case (533 bytes, text/html)
2011-03-23 11:41 PDT, Ian Ellison-Taylor 		no flags Details
Simpler test case (224 bytes, text/html)
2011-03-23 11:49 PDT, Ian Ellison-Taylor 		no flags Details
Patch. (3.98 KB, patch)
2011-04-30 21:03 PDT, Yael 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Ellison-Taylor 2011-03-23 11:41:04 PDT 
Created attachment 86654 [details]
nth-child(n) test case

The nth-child(n) CSS3 test fails although nth-child(1n) passes.

See the attached test, the background for the 4 elements should be red.
Comment 1 Ian Ellison-Taylor 2011-03-23 11:49:42 PDT 
Created attachment 86658 [details]
Simpler test case

Added a simpler test from Tab, text in the test should be green
Comment 2 Lea Verou 2011-04-02 07:46:15 PDT 
FWIW, here's another testcase: http://jsfiddle.net/leaverou/Cum32/
Comment 3 Yael 2011-04-30 21:03:05 PDT 
Created attachment 91811 [details]
Patch.
Comment 4 Eric Seidel (no email) 2011-05-01 09:44:55 PDT 
Comment on attachment 91811 [details]
Patch.

OK.
Comment 5 Eric Seidel (no email) 2011-05-01 09:45:30 PDT 
The spec link in the ChangeLog or source would have been nice. :)

Also generally our test cases use 4-space indent (like the rest of our code), but it's not a big deal.
Comment 6 WebKit Commit Bot 2011-05-01 10:08:37 PDT 
Comment on attachment 91811 [details]
Patch.

Clearing flags on attachment: 91811

Committed r85416: <http://trac.webkit.org/changeset/85416>
Comment 7 WebKit Commit Bot 2011-05-01 10:08:43 PDT 
All reviewed patches have been landed.  Closing bug.