Bug 56918 – [Qt] Teach build-jsc how to build JavaScriptCore on Qt

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Gabor Loki]

There is old issue on Qt, the JavaScriptCore and jsc binary cannot be built with build-jsc script. I hope it can be solved with a simple patch.

[Gabor Loki]

Created attachment 86605 [details]
build-jsc for Qt

[Andras Becsi]

Comment on attachment 86605 [details]
build-jsc for Qt

View in context: https://bugs.webkit.org/attachment.cgi?id=86605&action=review

LGTM, Just one little nitpick:

> Tools/Scripts/webkitdirs.pm:1577
> +    } else {
> +        $project = "";
> +    }

I think it would be better to use $project = 0; here and simply use !$project in the ifs, this would make the paths easier to read.

[Gabor Loki]

Created attachment 87130 [details]
build-jsc for Qt

[Csaba Osztrogonác]

Comment on attachment 87130 [details]
build-jsc for Qt

View in context: https://bugs.webkit.org/attachment.cgi?id=87130&action=review

I'm sure if it works with a little fix I suggested, but it is a little 
nasty hack, because the original code was hacked in itself.

r=me to go ahead, but we really need a serious refactor for buildQMakeProject() in the near future.

> Tools/Scripts/webkitdirs.pm:1637
>      if (grep { $_ eq "CONFIG+=webkit2"} @buildArgs) {
>          push @subdirs, "WebKit2";
>          if ( -e sourceDir() ."/Tools/DerivedSources.pro" ) {

We need one more if (!$project) guard to avoid building WebKit2, MiniBrowser and WTR.

[Gabor Loki]

Comment on attachment 87130 [details]
build-jsc for Qt

fixed and landed in r82228

[WebKit Review Bot]

http://trac.webkit.org/changeset/82228 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
svg/text/text-deco-01-b.svg