Bug 56882 - Add API to retrieve the audio hardware sample-rate
Summary: Add API to retrieve the audio hardware sample-rate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-22 16:59 PDT by Chris Rogers
Modified: 2011-03-23 14:38 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.35 KB, patch)
2011-03-22 17:02 PDT, Chris Rogers
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-03-22 16:59:58 PDT
Add API to retrieve the audio hardware sample-rate
Comment 1 Chris Rogers 2011-03-22 17:02:11 PDT
Created attachment 86546 [details]
Patch
Comment 2 Kenneth Russell 2011-03-22 17:07:34 PDT
Comment on attachment 86546 [details]
Patch

Looks fine to me; do you want to commit the Chromium side first?
Comment 3 Chris Rogers 2011-03-22 17:09:22 PDT
Thanks, Ken, yes I will have to.  Here's that CL:
http://codereview.chromium.org/6721015/
Comment 4 Chris Rogers 2011-03-23 13:04:50 PDT
Committed r81797: <http://trac.webkit.org/changeset/81797>
Comment 5 Tony Chang 2011-03-23 14:21:00 PDT
I'm getting a compilation error in Chromium with this change:

content/renderer/renderer_webkitclient_impl.cc: In member function ‘virtual WebKit::WebAudioDevice* RendererWebKitClientImpl::createAudioDevice(size_t, unsigned int, double, WebKit::WebAudioDevice::RenderCallback*)’:
content/renderer/renderer_webkitclient_impl.cc:553: error: cannot allocate an object of abstract type ‘RendererWebAudioDeviceImpl’
./content/renderer/renderer_webaudiodevice_impl.h:16: note:   because the following virtual functions are pure within ‘RendererWebAudioDeviceImpl’:
./third_party/WebKit/Source/WebKit/chromium/public/WebAudioDevice.h:51: note:   virtual double WebKit::WebAudioDevice::sampleRate()


It looks like renderer_webaudiodevice_impl.* needs to declare sampleRate()?
Comment 6 Chris Rogers 2011-03-23 14:28:31 PDT
Tony, sorry about that.  I'll land a temporary fix on the chromium-side...
Comment 7 Chris Rogers 2011-03-23 14:38:38 PDT
I have a patch about ready to land:
http://codereview.chromium.org/6733006/