Bug 56879 - OBJECT element with DivX source is always downloaded
: OBJECT element with DivX source is always downloaded
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Other Mac OS X 10.5
: P2 Normal
Assigned To: Anders Carlsson
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-22 16:50 PDT by Anders Carlsson
Modified: 2011-03-22 17:34 PDT (History)
0 users

See Also:


Attachments
Patch (6.87 KB, patch)
2011-03-22 16:56 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-03-22 16:50:56 PDT
OBJECT element with DivX source is always downloaded
Comment 1 Anders Carlsson 2011-03-22 16:56:49 PDT
Created attachment 86543 [details]
Patch
Comment 2 Sam Weinig 2011-03-22 17:03:17 PDT
Comment on attachment 86543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86543&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1270
> +        const Vector<String>& extensions = mimeClassInfo.extensions;
> +
> +        if (find(extensions.begin(), extensions.end(), extension) != extensions.end())
> +            return true;

Can this use the new Vector::contains()? Should we make mimeClassInfo.extensions a HashSet?
Comment 3 Anders Carlsson 2011-03-22 17:34:08 PDT
Committed r81732: <http://trac.webkit.org/changeset/81732>