Bug 56879 - OBJECT element with DivX source is always downloaded
: OBJECT element with DivX source is always downloaded
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Other Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-03-22 16:50 PST by
Modified: 2011-03-22 17:34 PST (History)


Attachments
Patch (6.87 KB, patch)
2011-03-22 16:56 PST, Anders Carlsson
sam: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-03-22 16:50:56 PST
OBJECT element with DivX source is always downloaded
------- Comment #1 From 2011-03-22 16:56:49 PST -------
Created an attachment (id=86543) [details]
Patch
------- Comment #2 From 2011-03-22 17:03:17 PST -------
(From update of attachment 86543 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=86543&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1270
> +        const Vector<String>& extensions = mimeClassInfo.extensions;
> +
> +        if (find(extensions.begin(), extensions.end(), extension) != extensions.end())
> +            return true;

Can this use the new Vector::contains()? Should we make mimeClassInfo.extensions a HashSet?
------- Comment #3 From 2011-03-22 17:34:08 PST -------
Committed r81732: <http://trac.webkit.org/changeset/81732>