Bug 56876 – WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread

This is blocking https://bugs.webkit.org/show_bug.cgi?id=56425 IconDatabase for WebKit2.

[Brady Eidson]

The expansion of the client interface is inspired by Patch #3 in https://bugs.webkit.org/show_bug.cgi?id=56425 and is laying the groundwork for future use.

[Brady Eidson]

Created attachment 86533 [details]
Patch v1

[WebKit Review Bot]

Attachment 86533 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/loader/icon/IconDatabase.cpp:88:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/loader/icon/IconDatabase.cpp:2123:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/loader/icon/IconDatabase.cpp:2147:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/loader/icon/IconDatabase.cpp:2171:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 4 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

(In reply to comment #3)
> Attachment 86533 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> 
> Source/WebCore/loader/icon/IconDatabase.cpp:88:  This { should be at the end of the previous line  [whitespace/braces] [4]
> Source/WebCore/loader/icon/IconDatabase.cpp:2123:  This { should be at the end of the previous line  [whitespace/braces] [4]
> Source/WebCore/loader/icon/IconDatabase.cpp:2147:  This { should be at the end of the previous line  [whitespace/braces] [4]
> Source/WebCore/loader/icon/IconDatabase.cpp:2171:  This { should be at the end of the previous line  [whitespace/braces] [4]
> Total errors found: 4 in 10 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

All style errors fixed locally for the landing, once I get a review.

[Sam Weinig]

Comment on attachment 86533 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=86533&action=review

>> Source/WebCore/loader/icon/IconDatabase.cpp:88
>> +{
> 
> This { should be at the end of the previous line  [whitespace/braces] [4]

I agree with the mighty style bot.

[Brady Eidson]

r81719