We should prefix the instance variables HTMLFrameSetElement::{noresize, frameborder, and frameBorderSet} with "m_" to conform to the WebKit Code style guidelines.
Created attachment 86525 [details] Patch Renamed HTMLFrameSetElement::frameBorderSet to HTMLFrameSetElement::m_frameborderSet since frameborder to match the name of the HTML attribute that corresponds to this instance variable.
Committed r81787: <http://trac.webkit.org/changeset/81787>
Nice to add an m and underscore but also would be great to give these better names.
(In reply to comment #3) > Nice to add an m and underscore but also would be great to give these better names. I agree. I was not very satisfied with these names or the names, but I couldn't think of any better names at the time. I am open to suggestions. Let me know if you would like me to roll out changeset 81787 <http://trac.webkit.org/changeset/81787> and/or feel free to roll it out. For frameBorderSet, I was originally thinking m_hasFrameborderSet, m_isFrameborderSet, or m_wasFrameborderAttributeSpecified. Similarly, I thought to rename frameborder to m_hasFrameBorder to be consistent with the getter of the same name. Note, I am also unhappy about the names of the existing instance variables m_borderSet, m_border, or m_borderColorSet. We should come up with some convention so that we can rename m_borderSet, m_border, m_borderColorSet, m_frameborder, m_frameborderSet, and m_noresize. At the time I wrote this patch, I chose to defer more descriptive renames and make frameborder, frameBorderSet, and noresize more consistent to the names of the existing instance variables m_border, m_borderSet because I was unsure of the naming convention I would use for renaming m_borderSet, m_border, and m_borderColorSet and was worried that committing subsequent patches that would change the convention would be noisy.
(In reply to comment #4) > (In reply to comment #3) > > Nice to add an m and underscore but also would be great to give these better names. > > I agree. I was not very satisfied with these names or the names, but I couldn't think of any better names This should read: I agree. I was not very satisfied with these names, but I couldn't think of a better naming convention at the time.
Comment on attachment 86525 [details] Patch Clearing review flag and marking as obsolete so as to remove this patch from the commit queue. We should still think about a better naming convention for these variables.
These seem okay as-is, especially given it's a legacy element. Might as well name the members in a way that matches the specification.
<rdar://problem/120248244>