Bug 56869 – Make horizontal writing mode a bit on RenderObject for speed

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

If it's a simple bit on an inlined RenderObject accessor, that should help with the speed of the question.

[Dave Hyatt]

Created attachment 86520 [details]
Patch

[WebKit Review Bot]

Attachment 86520 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/rendering/RenderTableCell.cpp:1049:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderBlock.h:468:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/rendering/RenderBlock.h:476:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 86520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86520&action=review

> Source/WebCore/rendering/RenderObject.h:864
> +    bool m_horizontalWritingMode : 1;

Unaligned!

What does this to do:

    // 32 bits have been used here. THERE ARE NO FREE BITS AVAILABLE.

Though by my count this is the 32nd bit. I'm sure we could get rid of m_isDragging if we need to. What a waste of a bit.

[Dave Hyatt]

Fixed in r81716.

[James Robinson]

I guess the scary comment on line 840 of RenderObject.h is accurate now :)