Bug 56869 - Make horizontal writing mode a bit on RenderObject for speed
Summary: Make horizontal writing mode a bit on RenderObject for speed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-22 15:13 PDT by Dave Hyatt
Modified: 2011-03-22 16:26 PDT (History)
2 users (show)

See Also:

Attachments
Patch (65.29 KB, patch)
2011-03-22 15:27 PDT, Dave Hyatt 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2011-03-22 15:13:30 PDT 
If it's a simple bit on an inlined RenderObject accessor, that should help with the speed of the question.
Comment 1 Dave Hyatt 2011-03-22 15:27:54 PDT 
Created attachment 86520 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-22 15:30:19 PDT 
Attachment 86520 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/rendering/RenderTableCell.cpp:1049:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderBlock.h:468:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/rendering/RenderBlock.h:476:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2011-03-22 15:59:38 PDT 
Comment on attachment 86520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86520&action=review

> Source/WebCore/rendering/RenderObject.h:864
> +    bool m_horizontalWritingMode : 1;

Unaligned!

What does this to do:

    // 32 bits have been used here. THERE ARE NO FREE BITS AVAILABLE.

Though by my count this is the 32nd bit. I'm sure we could get rid of m_isDragging if we need to. What a waste of a bit.
Comment 4 Dave Hyatt 2011-03-22 16:22:08 PDT 
Fixed in r81716.
Comment 5 James Robinson 2011-03-22 16:26:03 PDT 
I guess the scary comment on line 840 of RenderObject.h is accurate now :)