Bug 56857 - [chromium] Make WebTextCheckingResult's members be public in preparation for converting it to a struct
Summary: [chromium] Make WebTextCheckingResult's members be public in preparation for ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: John Abd-El-Malek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-22 12:44 PDT by John Abd-El-Malek
Modified: 2011-04-03 04:09 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.68 KB, patch)
2011-03-22 12:44 PDT, John Abd-El-Malek
no flags Details | Formatted Diff | Diff
Patch (3.47 KB, patch)
2011-03-22 14:55 PDT, John Abd-El-Malek
no flags Details | Formatted Diff | Diff
Patch (3.47 KB, patch)
2011-03-22 16:08 PDT, John Abd-El-Malek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Abd-El-Malek 2011-03-22 12:44:08 PDT
[chromium] Make WebTextCheckingResult's members be public in preparation for converting it to a struct
Comment 1 John Abd-El-Malek 2011-03-22 12:44:26 PDT
Created attachment 86494 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-22 13:07:33 PDT
Attachment 86494 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8218955
Comment 3 John Abd-El-Malek 2011-03-22 14:55:19 PDT
Created attachment 86513 [details]
Patch
Comment 4 John Abd-El-Malek 2011-03-22 14:56:00 PDT
updated patch per discussion so that "m_" is removed from the variable names.
Comment 5 Tony Chang 2011-03-22 15:06:27 PDT
Comment on attachment 86513 [details]
Patch

The change is fine, but looks like we can't roll chromium deps because ui_unittests.gypi is trying to pull in chrome.gyp.  Let me see if I can fix that dependency first.
Comment 6 WebKit Review Bot 2011-03-22 15:39:40 PDT
Attachment 86513 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8222500
Comment 7 John Abd-El-Malek 2011-03-22 16:08:58 PDT
Created attachment 86531 [details]
Patch
Comment 8 John Abd-El-Malek 2011-03-22 17:25:06 PDT
Committed r81729: <http://trac.webkit.org/changeset/81729>
Comment 9 Hajime Morrita 2011-03-22 18:52:13 PDT
Should this be a struct? It looks there is some convention that I miss...
Comment 10 Ryosuke Niwa 2011-04-03 04:09:30 PDT
Comment on attachment 86531 [details]
Patch

Clearing r+ of the landed patch.