Bug 56849 – REGRESSION: WK2: AX: PDF in Safari no longer accessible.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

1) Open a page in Safari containing a PDF document.
2) Using VoiceOver, navigate to the scroll area.
3) Find that there appears to be nothing there.

[chris fleizach]

Created attachment 86484 [details]
patch

[Darin Adler]

Comment on attachment 86484 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86484&action=review

review- because of the bad cast; otherwise looks good

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1611
> +        return [NSArray arrayWithObjects:child, nil];

This will return an empty array instead of nil in cases where the old code returned nil. How about calling [NSArray arrayWithObject:] explicitly in both cases above instead of using a local variable?

> Source/WebKit2/UIProcess/API/mac/PDFViewController.h:55
> +    WKView* pdfView() const { return static_cast<WKView*>(m_wkPDFView.get()); }

This is a bad cast, and incorrect. This function should be not be inline. I should be in the .mm file where the compiler can see the WKPDFView class. And the return type should be NSView *.

[chris fleizach]

Created attachment 86554 [details]
patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 86554 [details]:

inspector/debugger/debug-inlined-scripts.html bug 56900 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 86554 [details]
patch

Clearing flags on attachment: 86554

Committed r81755: <http://trac.webkit.org/changeset/81755>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.