Bug 56847 - WebKit2: Cannot make a selection past the end of the visible page (no autoscrolling)
Summary: WebKit2: Cannot make a selection past the end of the visible page (no autoscr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-22 11:17 PDT by Sam Weinig
Modified: 2011-04-06 17:53 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2011-03-22 11:19 PDT, Sam Weinig 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-03-22 11:17:45 PDT 
WebKit2: Cannot make a selection past the end of the visible page (no autoscrolling)
Comment 1 Sam Weinig 2011-03-22 11:19:19 PDT 
Created attachment 86482 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-03-22 11:24:44 PDT 
Comment on attachment 86482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86482&action=review

> Source/WebKit2/Shared/mac/WebEventFactory.mm:45
> +    if (!pressedMouseButtons)
> +        return WebMouseEvent::NoButton;
> +    if (pressedMouseButtons == 1 << 0)
> +        return WebMouseEvent::LeftButton;
> +    if (pressedMouseButtons == 1 << 1)
> +        return WebMouseEvent::RightButton;

Surprising that there aren't constants for these!
Comment 3 Adele Peterson 2011-04-06 17:53:07 PDT 
Fixed in r81679.