Bug 56843 - [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
Summary: [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-22 10:44 PDT by Yury Semikhatsky
Modified: 2011-03-23 05:57 PDT (History)
13 users (show)

See Also:

Attachments
Patch (8.98 KB, patch)
2011-03-22 10:55 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (13.15 KB, patch)
2011-03-22 23:31 PDT, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
Remove debuggerScriptSource implementation from DRT. (1.88 KB, patch)
2011-03-23 03:32 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Remove references to DebuggerScript.js from DRT and Qt port. (4.83 KB, patch)
2011-03-23 03:38 PDT, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
Remove DebuggerScript.js from Chromium resource bundle. (1.44 KB, patch)
2011-03-23 03:51 PDT, Yury Semikhatsky 		pfeldman: review-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-03-22 10:44:58 PDT 
Now DebuggerScript.js is provided to v8/ScriptDebugServer by WebKit layer. The script itself is a part of WebCore and it would be nice to avoid this round-trip. We already do the same thing with InjectedScriptSource.js
Comment 1 Yury Semikhatsky 2011-03-22 10:55:34 PDT 
Created attachment 86479 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-22 10:58:34 PDT 
Attachment 86479 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/xxd.pl:44:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2011-03-22 11:03:19 PDT 
Attachment 86479 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8218884
Comment 4 Early Warning System Bot 2011-03-22 11:10:39 PDT 
Attachment 86479 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8228295
Comment 5 Pavel Feldman 2011-03-22 11:47:13 PDT 
Comment on attachment 86479 [details]
Patch

This seems to break too many bots.
Comment 6 WebKit Review Bot 2011-03-22 13:22:26 PDT 
Attachment 86479 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8222437
Comment 7 Yury Semikhatsky 2011-03-22 22:14:01 PDT 
(In reply to comment #5)
> (From update of attachment 86479 [details])
> This seems to break too many bots.

For some reason InjectedScriptSource_js wasn't regenerated after xxd.pl changes.
Comment 8 Yury Semikhatsky 2011-03-22 23:31:06 PDT 
Created attachment 86574 [details]
Patch
Comment 9 Pavel Feldman 2011-03-23 02:48:32 PDT 
Comment on attachment 86574 [details]
Patch

Use input and output aliases please.
Comment 10 Yury Semikhatsky 2011-03-23 03:10:05 PDT 
Committed r81758: <http://trac.webkit.org/changeset/81758>
Comment 11 Yury Semikhatsky 2011-03-23 03:16:02 PDT 
Some more cleanup should be done.
Comment 12 Yury Semikhatsky 2011-03-23 03:32:07 PDT 
Created attachment 86595 [details]
Remove debuggerScriptSource implementation from DRT.
Comment 13 Yury Semikhatsky 2011-03-23 03:38:12 PDT 
Created attachment 86596 [details]
Remove references to DebuggerScript.js from DRT and Qt port.
Comment 14 Yury Semikhatsky 2011-03-23 03:51:19 PDT 
Created attachment 86598 [details]
Remove DebuggerScript.js from Chromium resource bundle.

This one should be landed once there are no references to the id from Chromium code.
Comment 15 WebKit Review Bot 2011-03-23 03:56:11 PDT 
Attachment 86598 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8221875
Comment 16 Yury Semikhatsky 2011-03-23 04:10:07 PDT 
Committed r81762
Comment 17 Pavel Feldman 2011-03-23 04:13:54 PDT 
Comment on attachment 86598 [details]
Remove DebuggerScript.js from Chromium resource bundle.

Please do patch per bug. Or land things like this as not reviewed.
Comment 18 Yury Semikhatsky 2011-03-23 05:57:46 PDT 
Will fix the rest in separate bugs. Closing this one.