Bug 56841 – Web Inspector: add test for bug 56747 (scripts panel is broken when frontend is reopened).

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: add test for bug 56747.

[Pavel Podivilov]

Created attachment 86472 [details]
Patch.

[Yury Semikhatsky]

Comment on attachment 86472 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=86472&action=review

> LayoutTests/http/tests/inspector/inspector-test.js:262
> +var reopenFrontendTestCallId = 2;

Can we make do without all these magical numbers?

> LayoutTests/inspector/debugger/open-close-open.html:12
> +        layoutTestController.showWebInspector();

I don't see the inspector close before it's shown again. Am I missing something?

> LayoutTests/inspector/debugger/open-close-open.html:40
> +https://bugs.webkit.org/show_bug.cgi?id=56747

This link should be <a href=>

[Pavel Feldman]

Comment on attachment 86472 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=86472&action=review

> LayoutTests/http/tests/inspector/inspector-test.js:338
> +        setTimeout(function() {

And without magical timeouts?

[Pavel Podivilov]

Created attachment 86593 [details]
Patch.

[Pavel Podivilov]

(In reply to comment #2)
> (From update of attachment 86472 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86472&action=review
> 
> > LayoutTests/http/tests/inspector/inspector-test.js:262
> > +var reopenFrontendTestCallId = 2;
> 
> Can we make do without all these magical numbers?
> 
> > LayoutTests/inspector/debugger/open-close-open.html:12
> > +        layoutTestController.showWebInspector();
> 
> I don't see the inspector close before it's shown again. Am I missing something?
> 
> > LayoutTests/inspector/debugger/open-close-open.html:40
> > +https://bugs.webkit.org/show_bug.cgi?id=56747
> 
> This link should be <a href=>

Done.

[Pavel Feldman]

Comment on attachment 86593 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=86593&action=review

> LayoutTests/platform/mac-wk2/Skipped:2259
> +inspector/debugger/open-close-open.html

How is this test different from the inspector-enabled/open-close-open? It will result in confusion when one of them fails.

[Pavel Podivilov]

Created attachment 86912 [details]
Patch.

[Pavel Podivilov]

(In reply to comment #6)
> (From update of attachment 86593 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86593&action=review
> 
> > LayoutTests/platform/mac-wk2/Skipped:2259
> > +inspector/debugger/open-close-open.html
> 
> How is this test different from the inspector-enabled/open-close-open? It will result in confusion when one of them fails.

Removed the old test.

[Pavel Podivilov]

Committed r82435: <http://trac.webkit.org/changeset/82435>