Bug 56841 - Web Inspector: add test for bug 56747 (scripts panel is broken when frontend is reopened).
Summary: Web Inspector: add test for bug 56747 (scripts panel is broken when frontend ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-22 10:25 PDT by Pavel Podivilov
Modified: 2011-03-30 06:54 PDT (History)
9 users (show)

See Also:

Attachments
Patch. (5.26 KB, patch)
2011-03-22 10:26 PDT, Pavel Podivilov 		pfeldman: review-
Details | Formatted Diff | Diff
Patch. (6.18 KB, patch)
2011-03-23 03:15 PDT, Pavel Podivilov 		pfeldman: review-
Details | Formatted Diff | Diff
Patch. (8.98 KB, patch)
2011-03-25 02:49 PDT, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-03-22 10:25:58 PDT 
Web Inspector: add test for bug 56747.
Comment 1 Pavel Podivilov 2011-03-22 10:26:41 PDT 
Created attachment 86472 [details]
Patch.
Comment 2 Yury Semikhatsky 2011-03-22 11:02:45 PDT 
Comment on attachment 86472 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=86472&action=review

> LayoutTests/http/tests/inspector/inspector-test.js:262
> +var reopenFrontendTestCallId = 2;

Can we make do without all these magical numbers?

> LayoutTests/inspector/debugger/open-close-open.html:12
> +        layoutTestController.showWebInspector();

I don't see the inspector close before it's shown again. Am I missing something?

> LayoutTests/inspector/debugger/open-close-open.html:40
> +https://bugs.webkit.org/show_bug.cgi?id=56747

This link should be <a href=>
Comment 3 Pavel Feldman 2011-03-22 11:48:34 PDT 
Comment on attachment 86472 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=86472&action=review

> LayoutTests/http/tests/inspector/inspector-test.js:338
> +        setTimeout(function() {

And without magical timeouts?
Comment 4 Pavel Podivilov 2011-03-23 03:15:52 PDT 
Created attachment 86593 [details]
Patch.
Comment 5 Pavel Podivilov 2011-03-24 02:38:06 PDT 
(In reply to comment #2)
> (From update of attachment 86472 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86472&action=review
> 
> > LayoutTests/http/tests/inspector/inspector-test.js:262
> > +var reopenFrontendTestCallId = 2;
> 
> Can we make do without all these magical numbers?
> 
> > LayoutTests/inspector/debugger/open-close-open.html:12
> > +        layoutTestController.showWebInspector();
> 
> I don't see the inspector close before it's shown again. Am I missing something?
> 
> > LayoutTests/inspector/debugger/open-close-open.html:40
> > +https://bugs.webkit.org/show_bug.cgi?id=56747
> 
> This link should be <a href=>

Done.
Comment 6 Pavel Feldman 2011-03-24 11:23:45 PDT 
Comment on attachment 86593 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=86593&action=review

> LayoutTests/platform/mac-wk2/Skipped:2259
> +inspector/debugger/open-close-open.html

How is this test different from the inspector-enabled/open-close-open? It will result in confusion when one of them fails.
Comment 7 Pavel Podivilov 2011-03-25 02:49:28 PDT 
Created attachment 86912 [details]
Patch.
Comment 8 Pavel Podivilov 2011-03-25 05:45:00 PDT 
(In reply to comment #6)
> (From update of attachment 86593 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86593&action=review
> 
> > LayoutTests/platform/mac-wk2/Skipped:2259
> > +inspector/debugger/open-close-open.html
> 
> How is this test different from the inspector-enabled/open-close-open? It will result in confusion when one of them fails.

Removed the old test.
Comment 9 Pavel Podivilov 2011-03-30 06:54:25 PDT 
Committed r82435: <http://trac.webkit.org/changeset/82435>