Bug 56837 - Allow WebMediaPlayerClient to call playbackStatechanged in MediaPlayer
Summary: Allow WebMediaPlayerClient to call playbackStatechanged in MediaPlayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-22 09:28 PDT by Min Qin
Modified: 2011-03-24 19:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.66 KB, patch)
2011-03-22 10:01 PDT, Min Qin 		no flags Details | Formatted Diff | Diff
Patch (2.66 KB, patch)
2011-03-24 16:16 PDT, Min Qin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Min Qin 2011-03-22 09:28:22 PDT 
Once we start playing a media url in WebMediaPlayerImpl, m_paused in HTMLMediaElement will always set to true, even if the whole stream has been consumed by the pipeline.
This CL allows the WebMediaPlayerClient to inform MediaPlayer that playstate has changed (e.g., pipeline crashed due to some errors and the WebMediaPlayerImpl is in state "paused")
Comment 1 Min Qin 2011-03-22 10:01:54 PDT 
Created attachment 86466 [details]
Patch
Comment 2 Andrew Scherkus 2011-03-24 13:56:39 PDT 
Comment on attachment 86466 [details]
Patch

Looks good to me.
Comment 3 James Robinson 2011-03-24 14:02:43 PDT 
Can you make a test?
Comment 4 James Robinson 2011-03-24 14:06:15 PDT 
Comment on attachment 86466 [details]
Patch

OK
Comment 5 Min Qin 2011-03-24 16:16:13 PDT 
Created attachment 86852 [details]
Patch
Comment 6 WebKit Commit Bot 2011-03-24 19:05:50 PDT 
The commit-queue encountered the following flaky tests while processing attachment 86852 [details]:

http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2011-03-24 19:09:22 PDT 
Comment on attachment 86852 [details]
Patch

Clearing flags on attachment: 86852

Committed r81930: <http://trac.webkit.org/changeset/81930>
Comment 8 WebKit Commit Bot 2011-03-24 19:09:26 PDT 
All reviewed patches have been landed.  Closing bug.