Bug 56835 – Web Inspector: Add tests for HeapSnapshot module

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mikhail Naganov]

The logic is non-trivial, and tests are required.

[Mikhail Naganov]

Created attachment 86463 [details]
patch

[Mikhail Naganov]

Created attachment 86761 [details]
reuse more capabilities of test infrastructure

[Pavel Feldman]

Comment on attachment 86761 [details]
reuse more capabilities of test infrastructure

View in context: https://bugs.webkit.org/attachment.cgi?id=86761&action=review

> LayoutTests/http/tests/inspector/heap-snapshot-test.js:1
> +var initialize_HeapSnapshotTest = function() {

You should place your utility test into inspector/profiler since you don't have tests that require network interaction / serving off http

> LayoutTests/inspector/profiler/heap-snapshot-expected.txt:4
> +Running: heapSnapshotNodeSimpleTest

It would be nice if your tests were printing something to make sure something is happening.

[Mikhail Naganov]

(In reply to comment #3)
> (From update of attachment 86761 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86761&action=review
> 
> > LayoutTests/http/tests/inspector/heap-snapshot-test.js:1
> > +var initialize_HeapSnapshotTest = function() {
> 
> You should place your utility test into inspector/profiler since you don't have tests that require network interaction / serving off http

Moved.

> 
> > LayoutTests/inspector/profiler/heap-snapshot-expected.txt:4
> > +Running: heapSnapshotNodeSimpleTest
> 
> It would be nice if your tests were printing something to make sure something is happening.

They will scream if something is wrong. I think it's enough that the framework prints the name of the test currently running.

[Mikhail Naganov]

Manually committed http://trac.webkit.org/changeset/81946


2011-03-24  Mikhail Naganov  <[e-mail]>

        Reviewed by Pavel Feldman.

        Web Inspector: Add tests for HeapSnapshot module.
        https://bugs.webkit.org/show_bug.cgi?id=56835

        * http/tests/inspector/heap-snapshot-test.js: Added.
        (initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject):
        (initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
        (initialize_HeapSnapshotTest):
        * inspector/profiler/heap-snapshot-expected.txt: Added.
        * inspector/profiler/heap-snapshot.html: Added.