Bug 56819 - [EFL] Change return values with better one in ewk_setting's functions
Summary: [EFL] Change return values with better one in ewk_setting's functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-22 02:24 PDT by Gyuyoung Kim
Modified: 2011-03-22 11:39 PDT (History)
8 users (show)

See Also:

Attachments
Proposed Patch (1.48 KB, patch)
2011-03-22 02:33 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Proposed Patch (1.80 KB, patch)
2011-03-22 02:40 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-03-22 02:24:55 PDT 
In ewk_settings_cache_directory_path_set_xxx, they return false value when soup is disabled. It is better to use EINA_SAFETY_ON_TRUE_RETURN_XXX.
Comment 1 Gyuyoung Kim 2011-03-22 02:33:03 PDT 
Created attachment 86447 [details]
Proposed Patch
Comment 2 WebKit Review Bot 2011-03-22 02:35:12 PDT 
Attachment 86447 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1

Source/WebKit/efl/ewk/ewk_settings.cpp:382:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gyuyoung Kim 2011-03-22 02:40:14 PDT 
Created attachment 86448 [details]
Proposed Patch

Fix style error.
Comment 4 Antonio Gomes 2011-03-22 08:39:18 PDT 
Comment on attachment 86448 [details]
Proposed Patch

rs=me
Comment 5 WebKit Commit Bot 2011-03-22 09:03:59 PDT 
Comment on attachment 86448 [details]
Proposed Patch

Clearing flags on attachment: 86448

Committed r81670: <http://trac.webkit.org/changeset/81670>
Comment 6 WebKit Commit Bot 2011-03-22 09:04:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2011-03-22 11:39:43 PDT 
http://trac.webkit.org/changeset/81670 might have broken GTK Linux 32-bit Debug
The following tests are not passing:
inspector/debugger/debug-inlined-scripts.html