RESOLVED FIXED 56819
[EFL] Change return values with better one in ewk_setting's functions 
https://bugs.webkit.org/show_bug.cgi?id=56819
Summary [EFL] Change return values with better one in ewk_setting's functions
Gyuyoung Kim
Reported 2011-03-22 02:24:55 PDT
In ewk_settings_cache_directory_path_set_xxx, they return false value when soup is disabled. It is better to use EINA_SAFETY_ON_TRUE_RETURN_XXX.
Attachments
Proposed Patch (1.48 KB, patch)
2011-03-22 02:33 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Proposed Patch (1.80 KB, patch)
2011-03-22 02:40 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2011-03-22 02:33:03 PDT
Created attachment 86447 [details] Proposed Patch
WebKit Review Bot
Comment 2 2011-03-22 02:35:12 PDT
Attachment 86447 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ewk/ewk_settings.cpp:382: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gyuyoung Kim
Comment 3 2011-03-22 02:40:14 PDT
Created attachment 86448 [details] Proposed Patch Fix style error.
Antonio Gomes
Comment 4 2011-03-22 08:39:18 PDT
Comment on attachment 86448 [details] Proposed Patch rs=me
WebKit Commit Bot
Comment 5 2011-03-22 09:03:59 PDT
Comment on attachment 86448 [details] Proposed Patch Clearing flags on attachment: 86448 Committed r81670: <http://trac.webkit.org/changeset/81670>
WebKit Commit Bot
Comment 6 2011-03-22 09:04:05 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2011-03-22 11:39:43 PDT
http://trac.webkit.org/changeset/81670 might have broken GTK Linux 32-bit Debug The following tests are not passing: inspector/debugger/debug-inlined-scripts.html
Note You need to log in before you can comment on or make changes to this bug.