Bug 56806 - Web Inspector: protocol cleanup. ConsoleAgent.
Summary: Web Inspector: protocol cleanup. ConsoleAgent.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks: 54856
  Show dependency tree / graph
 
Reported: 2011-03-22 00:31 PDT by Ilya Tikhonovsky
Modified: 2011-03-22 02:22 PDT (History)
10 users (show)

See Also:

Attachments
[patch] initial version (12.27 KB, patch)
2011-03-22 00:36 PDT, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2011-03-22 00:31:20 PDT 
see protocol metabug:
- All events should use notification wording, not command wording: addConsoleMessage->consoleMessage, updateConsoleMessageRepeatCount->consoleMessageRepeatCountUpdates, etc.


rename: void setConsoleMessagesEnabled(in boolean enabled, out boolean newState); => void enable(out long expiredMessagesCount);
new method: disable()
deleted method: [event] void consoleMessageExpiredCountUpdate(out unsigned long count); delete it. The counter will be transfered as out argument of enable command.
Comment 1 Ilya Tikhonovsky 2011-03-22 00:36:58 PDT 
Created attachment 86435 [details]
[patch] initial version
Comment 2 Yury Semikhatsky 2011-03-22 02:13:08 PDT 
Comment on attachment 86435 [details]
[patch] initial version

View in context: https://bugs.webkit.org/attachment.cgi?id=86435&action=review

> Source/WebCore/inspector/InspectorConsoleAgent.cpp:88
> +    unsigned messageCount = m_consoleMessages.size();

unsigned -> size_t ?
Comment 3 Ilya Tikhonovsky 2011-03-22 02:22:15 PDT 
Committed r81650: <http://trac.webkit.org/changeset/81650>