WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
56806
Web Inspector: protocol cleanup. ConsoleAgent.
https://bugs.webkit.org/show_bug.cgi?id=56806
Summary
Web Inspector: protocol cleanup. ConsoleAgent.
Ilya Tikhonovsky
Reported
2011-03-22 00:31:20 PDT
see protocol metabug: - All events should use notification wording, not command wording: addConsoleMessage->consoleMessage, updateConsoleMessageRepeatCount->consoleMessageRepeatCountUpdates, etc. rename: void setConsoleMessagesEnabled(in boolean enabled, out boolean newState); => void enable(out long expiredMessagesCount); new method: disable() deleted method: [event] void consoleMessageExpiredCountUpdate(out unsigned long count); delete it. The counter will be transfered as out argument of enable command.
Attachments
[patch] initial version
(12.27 KB, patch)
2011-03-22 00:36 PDT
,
Ilya Tikhonovsky
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2011-03-22 00:36:58 PDT
Created
attachment 86435
[details]
[patch] initial version
Yury Semikhatsky
Comment 2
2011-03-22 02:13:08 PDT
Comment on
attachment 86435
[details]
[patch] initial version View in context:
https://bugs.webkit.org/attachment.cgi?id=86435&action=review
> Source/WebCore/inspector/InspectorConsoleAgent.cpp:88 > + unsigned messageCount = m_consoleMessages.size();
unsigned -> size_t ?
Ilya Tikhonovsky
Comment 3
2011-03-22 02:22:15 PDT
Committed
r81650
: <
http://trac.webkit.org/changeset/81650
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug