Bug 56801 – REGRESSION(r81597): Change results in lots of unexpected flaky on the dashboard. (Requested by pfeldman on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/81597 broke the build:
Change results in lots of unexpected flaky on the dashboard. (Requested by pfeldman on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 86420 [details]
ROLLOUT of r81597

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[Pavel Feldman]

Comment on attachment 86420 [details]
ROLLOUT of r81597

Clearing flags on attachment: 86420

Committed r81645: <http://trac.webkit.org/changeset/81645>

[Pavel Feldman]

All reviewed patches have been landed.  Closing bug.

[Dirk Pranke]

If this test made a bunch of tests become suddenly flaky, then that means that they were sensitive to the order they were being run in. I think the right thing to do is probably to mark them as flaky in the expectations and then fix them, rather than roll this out.

(Of course, you've already rolled this out, so I suppose I mean that we should re-land this and then triage and mark as flaky ...).

There isn't really any good way to figure out what the flakiness will be without landing this and getting some runs in.

Thoughts?

[Dirk Pranke]

Per comment on bug 56760, Mihai suggests that this change actually made the http tests run backwards on the chromium linux bots. That would be an actual bad thing deserving of roll-out, rather than just flakiness.