RESOLVED FIXED 56798
add autorelease pools to WebKit2 control flow 
https://bugs.webkit.org/show_bug.cgi?id=56798
Summary add autorelease pools to WebKit2 control flow
Stephanie Lewis
Reported 2011-03-21 19:45:17 PDT
wrap autorelease pools around calls that can have pathological memory growth on Membuster
Attachments
patch (2.94 KB, patch)
2011-03-21 22:10 PDT, Stephanie Lewis 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephanie Lewis
Comment 1 2011-03-21 22:10:35 PDT
Created attachment 86418 [details] patch
WebKit Review Bot
Comment 2 2011-03-21 22:13:36 PDT
Attachment 86418 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Platform/mac/RunLoopMac.mm:36: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/Platform/mac/RunLoopMac.mm:37: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/Platform/mac/RunLoopMac.mm:38: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/Platform/mac/RunLoopMac.mm:106: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/Platform/mac/RunLoopMac.mm:107: Line contains tab character. [whitespace/tab] [5] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2011-03-22 17:47:42 PDT
Comment on attachment 86418 [details] patch r=me minus the tabs.
Geoffrey Garen
Comment 4 2011-03-22 22:05:21 PDT
http://trac.webkit.org/changeset/81734
Note You need to log in before you can comment on or make changes to this bug.