Bug 56798 - add autorelease pools to WebKit2 control flow
Summary: add autorelease pools to WebKit2 control flow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-21 19:45 PDT by Stephanie Lewis
Modified: 2011-03-22 22:05 PDT (History)
2 users (show)

See Also:

Attachments
patch (2.94 KB, patch)
2011-03-21 22:10 PDT, Stephanie Lewis 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2011-03-21 19:45:17 PDT 
wrap autorelease pools around calls that can have pathological memory growth on Membuster
Comment 1 Stephanie Lewis 2011-03-21 22:10:35 PDT 
Created attachment 86418 [details]
patch
Comment 2 WebKit Review Bot 2011-03-21 22:13:36 PDT 
Attachment 86418 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/Platform/mac/RunLoopMac.mm:36:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit2/Platform/mac/RunLoopMac.mm:37:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit2/Platform/mac/RunLoopMac.mm:38:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit2/Platform/mac/RunLoopMac.mm:106:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit2/Platform/mac/RunLoopMac.mm:107:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 5 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2011-03-22 17:47:42 PDT 
Comment on attachment 86418 [details]
patch

r=me minus the tabs.
Comment 4 Geoffrey Garen 2011-03-22 22:05:21 PDT 
http://trac.webkit.org/changeset/81734