Actually hook up WebKit2 logging on Mac.
Created attachment 86389 [details] Patch v1
Attachment 86389 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Platform/Logging.h:26: #ifndef header guard has wrong style, please use: WTF_Logging_h [build/header_guard] [5] Source/WebKit2/Platform/Logging.h:44: The parameter name "channel" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 86389 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=86389&action=review Please fix the style issues also. > Source/WebKit2/Platform/mac/Logging.mac.mm:35 > + if (logLevelString) { Can this be an early return instead? > Source/WebKit2/UIProcess/WebContext.cpp:131 > +#endif I think a blank line after the #endif would be slightly more pleasing on the eye.
(In reply to comment #3) > (From update of attachment 86389 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86389&action=review > > Please fix the style issues also. Fixed the argument name. Can't fix the header guard - each logging header needs to be unique. Breakage ensues otherwise. > > > Source/WebKit2/Platform/mac/Logging.mac.mm:35 > > + if (logLevelString) { > > Can this be an early return instead? Probably > > > Source/WebKit2/UIProcess/WebContext.cpp:131 > > +#endif > > I think a blank line after the #endif would be slightly more pleasing on the eye. K
Landed in r81628
r81631 fixed the mac release build.