Bug 56781 - Add --dsym switch to enable dsym generation when building with Xcode
Summary: Add --dsym switch to enable dsym generation when building with Xcode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-03-21 16:49 PDT by David Kilzer (:ddkilzer)
Modified: 2011-03-22 13:40 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.96 KB, patch)
2011-03-21 16:49 PDT, David Kilzer (:ddkilzer)
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2011-03-21 16:49:45 PDT
Created attachment 86387 [details]
Patch

Reviewed by NOBODY (OOPS!).

* Scripts/build-webkit: Updated usage statement to include
--dsym.
* Scripts/webkitdirs.pm: Added $generateDsym variable.
(generateDsym): Added. Call determineGenerateDsym() and
return $generateDsym.
(determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
$generateDsym.
(argumentsForXcode): Added.  Returns additional arguments for
xcodebuild based on command-line switches.
(XcodeOptions): Updated to include argumentsForXcode() in the
array returned.
---
 3 files changed, 40 insertions(+), 1 deletions(-)
Comment 1 David Kilzer (:ddkilzer) 2011-03-21 17:01:51 PDT
<rdar://problem/9136759>
Comment 2 Joseph Pecoraro 2011-03-21 19:09:45 PDT
Comment on attachment 86387 [details]
Patch

I notice some of the Perl functions do not use the optional "()" for empty
arguments. I'm happy with either style. Nice!
Comment 3 David Kilzer (:ddkilzer) 2011-03-22 13:40:46 PDT
Committed r81690: <http://trac.webkit.org/changeset/81690>