Bug 56726 - [EFL] Add sound / mute button to MediaControl UI
Summary: [EFL] Add sound / mute button to MediaControl UI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on: 55463
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-20 17:38 PDT by Gyuyoung Kim
Modified: 2011-03-24 23:57 PDT (History)
5 users (show)

See Also:

Attachments
Proposed Patch (12.03 KB, patch)
2011-03-20 18:08 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Modified Patch (10.28 KB, patch)
2011-03-24 06:15 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-03-20 17:38:03 PDT 
Add sound / mute button.
Comment 1 Gyuyoung Kim 2011-03-20 18:08:58 PDT 
Created attachment 86287 [details]
Proposed Patch
Comment 2 Lucas De Marchi 2011-03-23 14:12:00 PDT 
Comment on attachment 86287 [details]
Proposed Patch

The same problem as in bug 55463. Please, merge these in only 1 widget. Later on you might want to add more states indicating the volume level.
Comment 3 Gyuyoung Kim 2011-03-23 16:09:49 PDT 
Yes, I also do that. I am going to upload new patch.
Comment 4 Gyuyoung Kim 2011-03-24 06:15:34 PDT 
Created attachment 86763 [details]
Modified Patch

I modify this patch based on play button implementation. BTW, I'd like to volume control later.
Comment 5 Gyuyoung Kim 2011-03-24 06:15:58 PDT 
(In reply to comment #4)
> Created an attachment (id=86763) [details]
> Modified Patch
> 
> I modify this patch based on play button implementation.

 BTW, I'd like to add volume control later.
Comment 6 Lucas De Marchi 2011-03-24 16:57:52 PDT 
Comment on attachment 86763 [details]
Modified Patch

LGTM
Comment 7 WebKit Commit Bot 2011-03-24 23:53:37 PDT 
The commit-queue encountered the following flaky tests while processing attachment 86763 [details]:

inspector/debugger/debugger-expand-scope.html bug 57086 (author: pfeldman@chromium.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2011-03-24 23:57:18 PDT 
Comment on attachment 86763 [details]
Modified Patch

Clearing flags on attachment: 86763

Committed r81944: <http://trac.webkit.org/changeset/81944>
Comment 9 WebKit Commit Bot 2011-03-24 23:57:22 PDT 
All reviewed patches have been landed.  Closing bug.