Bug 56714 - Rename ThreadSafeShared to ThreadSafeRefCounted
Summary: Rename ThreadSafeShared to ThreadSafeRefCounted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-19 13:18 PDT by Bill Budge
Modified: 2011-03-20 16:32 PDT (History)
5 users (show)

See Also:

Attachments
Proposed Patch (72.98 KB, patch)
2011-03-19 17:47 PDT, Bill Budge 		no flags Details | Formatted Diff | Diff
Proposed Patch (72.50 KB, patch)
2011-03-19 17:57 PDT, Bill Budge 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch (72.46 KB, patch)
2011-03-20 08:14 PDT, Bill Budge 		abarth: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bill Budge 2011-03-19 13:18:22 PDT 
Rename to make it clear that it's a ref counted object.
Comment 1 Bill Budge 2011-03-19 17:47:42 PDT 
Created attachment 86275 [details]
Proposed Patch
Comment 2 Bill Budge 2011-03-19 17:57:15 PDT 
Created attachment 86276 [details]
Proposed Patch

Removed some stray pasted text in header.
Comment 3 Adam Barth 2011-03-19 18:02:51 PDT 
Comment on attachment 86276 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86276&action=review

Sounds like a good idea to me.  I see that it's on our list of renames we'd like to do in the future.  Thanks!

> Source/JavaScriptCore/wtf/CrossThreadRefCounted.h:41
>      // Used to allowing sharing data across classes and threads (like ThreadedSafeShared).

Missed this one?

> Source/JavaScriptGlue/gyp/JavaScriptGlue.gypi:1
> -{
> +ThreadSafeRefCounted{

Typo?
Comment 4 Bill Budge 2011-03-19 18:13:58 PDT 
Hi Adam, let me fix that (tomorrow though). I want to double-check the chrome side to make sure nothing breaks.
Comment 5 Bill Budge 2011-03-20 08:14:51 PDT 
Created attachment 86282 [details]
Proposed Patch

Fixed 2 errors.
Comment 6 Adam Barth 2011-03-20 11:00:34 PDT 
Comment on attachment 86282 [details]
Proposed Patch

Thanks!
Comment 7 WebKit Commit Bot 2011-03-20 11:03:15 PDT 
Comment on attachment 86282 [details]
Proposed Patch

Rejecting attachment 86282 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2

Last 500 characters of output:
ium/src/WorkerFileWriterCallbacksBridge.h
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file Tools/DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h
patching file Tools/DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h
rm 'Tools/DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h'
patching file Tools/Scripts/do-webcore-rename

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8211380
Comment 8 Adam Barth 2011-03-20 11:20:18 PDT 
The commit-queue hasn't been very good at renames recently.  We think it might be a recent regression.
Comment 9 Bill Budge 2011-03-20 12:44:27 PDT 
Is this a problem with the patch?
Comment 10 Adam Barth 2011-03-20 13:18:00 PDT 
(In reply to comment #9)
> Is this a problem with the patch?

Most likely not.  It's a problem with the tools.
Comment 11 Adam Barth 2011-03-20 13:25:38 PDT 
I would land this for you, but all my working copies have patches in the at the moment.
Comment 12 Bill Budge 2011-03-20 13:40:50 PDT 
No rush, but I'm curious - do patches become stale over time?
Comment 13 Adam Barth 2011-03-20 13:46:21 PDT 
(In reply to comment #12)
> No rush, but I'm curious - do patches become stale over time?

They do, but hopefully we'll get this landed for you before that happens.
Comment 14 David Levin 2011-03-20 15:07:14 PDT 
(In reply to comment #13)
> (In reply to comment #12)
> > No rush, but I'm curious - do patches become stale over time?
> 
> They do, but hopefully we'll get this landed for you before that happens.

I'll try to land it.
Comment 15 David Levin 2011-03-20 16:32:12 PDT 
Committed as http://trac.webkit.org/changeset/81567