Bug 56714 – Rename ThreadSafeShared to ThreadSafeRefCounted

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Bill Budge]

Rename to make it clear that it's a ref counted object.

[Bill Budge]

Created attachment 86275 [details]
Proposed Patch

[Bill Budge]

Created attachment 86276 [details]
Proposed Patch

Removed some stray pasted text in header.

[Adam Barth]

Comment on attachment 86276 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86276&action=review

Sounds like a good idea to me.  I see that it's on our list of renames we'd like to do in the future.  Thanks!

> Source/JavaScriptCore/wtf/CrossThreadRefCounted.h:41
>      // Used to allowing sharing data across classes and threads (like ThreadedSafeShared).

Missed this one?

> Source/JavaScriptGlue/gyp/JavaScriptGlue.gypi:1
> -{
> +ThreadSafeRefCounted{

Typo?

[Bill Budge]

Hi Adam, let me fix that (tomorrow though). I want to double-check the chrome side to make sure nothing breaks.

[Bill Budge]

Created attachment 86282 [details]
Proposed Patch

Fixed 2 errors.

[Adam Barth]

Comment on attachment 86282 [details]
Proposed Patch

Thanks!

[WebKit Commit Bot]

Comment on attachment 86282 [details]
Proposed Patch

Rejecting attachment 86282 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2

Last 500 characters of output:
ium/src/WorkerFileWriterCallbacksBridge.h
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file Tools/DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h
patching file Tools/DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h
rm 'Tools/DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h'
patching file Tools/Scripts/do-webcore-rename

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8211380

[Adam Barth]

The commit-queue hasn't been very good at renames recently.  We think it might be a recent regression.

[Bill Budge]

Is this a problem with the patch?

[Adam Barth]

(In reply to comment #9)
> Is this a problem with the patch?

Most likely not.  It's a problem with the tools.

[Adam Barth]

I would land this for you, but all my working copies have patches in the at the moment.

[Bill Budge]

No rush, but I'm curious - do patches become stale over time?

[Adam Barth]

(In reply to comment #12)
> No rush, but I'm curious - do patches become stale over time?

They do, but hopefully we'll get this landed for you before that happens.

[David Levin]

(In reply to comment #13)
> (In reply to comment #12)
> > No rush, but I'm curious - do patches become stale over time?
> 
> They do, but hopefully we'll get this landed for you before that happens.

I'll try to land it.

[David Levin]

Committed as http://trac.webkit.org/changeset/81567