Bug 56712 – [Qt] Remove support for Qt 4.6

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Andreas Kling]

As discussed on mailing list(s), we should remove support for Qt 4.6 from trunk.

[Andreas Kling]

Created attachment 86268 [details]
Proposed patch

[Benjamin Poulain]

Comment on attachment 86268 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86268&action=review

> Source/WebCore/platform/graphics/qt/FontQt.cpp:180
> +

Empty line? :)

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:44
>  #define SIGNAL_CONN Qt::DirectConnection

Why not replacing all the instance of SIGNAL_CONN by Qt::DirectConnection?

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:382
>              response.setHTTPHeaderField(QString::fromAscii(pair.first), QString::fromAscii(pair.second));

for a follow up: QString::fromAscii() should be QString::fromLatin1().

[Andreas Kling]

Created attachment 86269 [details]
Proposed patch v2

[Benjamin Poulain]

Comment on attachment 86269 [details]
Proposed patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=86269&action=review

R+ :)
Just update the code to match the coding style before landing.

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:553
>      if (m_resourceHandle->firstRequest().reportUploadProgress()) {
> -        connect(m_reply, SIGNAL(uploadProgress(qint64, qint64)),
> -                this, SLOT(uploadProgress(qint64, qint64)), SIGNAL_CONN);
> +        connect(m_reply, SIGNAL(uploadProgress(qint64, qint64)), this, SLOT(uploadProgress(qint64, qint64)));
>      }

Coding style, you don't need the brackets.

[Andreas Kling]

Committed r81553: <http://trac.webkit.org/changeset/81553>

[Yury Semikhatsky]

http://trac.webkit.org/wiki/BuildingQtOnLinux needs update. It states that minimal Qt version is still 4.6

[Benjamin Poulain]

(In reply to comment #6)
> http://trac.webkit.org/wiki/BuildingQtOnLinux needs update. It states that minimal Qt version is still 4.6

Thanks for reporting the doc issue, I fixed the wiki.