RESOLVED FIXED 56708
Web Inspector: make frameId in network agent of type string, not unsigned long. 
https://bugs.webkit.org/show_bug.cgi?id=56708
Summary Web Inspector: make frameId in network agent of type string, not unsigned long.
Pavel Feldman
Reported 2011-03-19 02:52:31 PDT
Today, frame's id is its address. Its propagation to the javascript is fishy (reinterpret cast + assumption that it fits). We should either introduce a counter for frames or use string identifier.
Attachments
Patch (14.56 KB, patch)
2011-03-19 03:46 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATCH] With right errors removed from header. (14.36 KB, patch)
2011-03-19 03:50 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-03-19 03:46:52 PDT
Created attachment 86258 [details] Patch
Pavel Feldman
Comment 2 2011-03-19 03:50:28 PDT
Created attachment 86259 [details] [PATCH] With right errors removed from header.
WebKit Review Bot
Comment 3 2011-03-19 03:52:56 PDT
Attachment 86258 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8200683
WebKit Review Bot
Comment 4 2011-03-19 03:55:25 PDT
Attachment 86258 [details] did not build on mac: Build output: http://queues.webkit.org/results/8207277
Ilya Tikhonovsky
Comment 5 2011-03-19 09:11:51 PDT
Comment on attachment 86259 [details] [PATCH] With right errors removed from header. lgtm
Yury Semikhatsky
Comment 6 2011-03-21 00:28:16 PDT
Comment on attachment 86259 [details] [PATCH] With right errors removed from header. View in context: https://bugs.webkit.org/attachment.cgi?id=86259&action=review > Source/WebCore/inspector/InspectorResourceAgent.cpp:236 > + unsigned long long address = reinterpret_cast<uintptr_t>(pointer); does unsigned long long always fit pointer type? > Source/WebCore/inspector/InspectorResourceAgent.cpp:238 > + return String::format("%.0llX", address); We should use a map address->id to enumerate all iframes instead of exposing raw address over the protocol.
Pavel Feldman
Comment 7 2011-03-21 00:45:14 PDT
Comment on attachment 86259 [details] [PATCH] With right errors removed from header. Clearing flags on attachment: 86259 Committed r81571: <http://trac.webkit.org/changeset/81571>
Pavel Feldman
Comment 8 2011-03-21 00:45:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.