Bug 56708 - Web Inspector: make frameId in network agent of type string, not unsigned long.
Summary: Web Inspector: make frameId in network agent of type string, not unsigned long.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-19 02:52 PDT by Pavel Feldman
Modified: 2011-03-21 00:45 PDT (History)
12 users (show)

See Also:

Attachments
Patch (14.56 KB, patch)
2011-03-19 03:46 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
[PATCH] With right errors removed from header. (14.36 KB, patch)
2011-03-19 03:50 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-03-19 02:52:31 PDT 
Today, frame's id is its address. Its propagation to the javascript is fishy (reinterpret cast + assumption that it fits). We should either introduce a counter for frames or use string identifier.
Comment 1 Pavel Feldman 2011-03-19 03:46:52 PDT 
Created attachment 86258 [details]
Patch
Comment 2 Pavel Feldman 2011-03-19 03:50:28 PDT 
Created attachment 86259 [details]
[PATCH] With right errors removed from header.
Comment 3 WebKit Review Bot 2011-03-19 03:52:56 PDT 
Attachment 86258 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8200683
Comment 4 WebKit Review Bot 2011-03-19 03:55:25 PDT 
Attachment 86258 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8207277
Comment 5 Ilya Tikhonovsky 2011-03-19 09:11:51 PDT 
Comment on attachment 86259 [details]
[PATCH] With right errors removed from header.

lgtm
Comment 6 Yury Semikhatsky 2011-03-21 00:28:16 PDT 
Comment on attachment 86259 [details]
[PATCH] With right errors removed from header.

View in context: https://bugs.webkit.org/attachment.cgi?id=86259&action=review

> Source/WebCore/inspector/InspectorResourceAgent.cpp:236
> +    unsigned long long address = reinterpret_cast<uintptr_t>(pointer);

does unsigned long long always fit pointer type?

> Source/WebCore/inspector/InspectorResourceAgent.cpp:238
> +    return String::format("%.0llX", address);

We should use a map address->id to enumerate all iframes instead of exposing raw address over the protocol.
Comment 7 Pavel Feldman 2011-03-21 00:45:14 PDT 
Comment on attachment 86259 [details]
[PATCH] With right errors removed from header.

Clearing flags on attachment: 86259

Committed r81571: <http://trac.webkit.org/changeset/81571>
Comment 8 Pavel Feldman 2011-03-21 00:45:23 PDT 
All reviewed patches have been landed.  Closing bug.