Bug 56685 - [Mac] webarchive/test-link-rel-icon.html fails
Summary: [Mac] webarchive/test-link-rel-icon.html fails
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 56663 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-03-18 14:48 PDT by Brady Eidson
Modified: 2013-05-22 15:31 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2011-03-18 14:48:01 PDT 
After a checkin in https://bugs.webkit.org/show_bug.cgi?id=56425 webarchive/test-link-rel-icon.html is now flaky.

I haven't been able to reproduce it locally on any OS.
There's a number of bots that don't show it at all.
I also cannot reproduce on the Leopard bot that showed the failure once after not showing it.
I *can* reproduce on the snow leopard bot that shows the failure.

It appears it's now in "flaky" territory, so we're adding it to the skipped list.
Comment 1 Brady Eidson 2011-03-18 14:50:22 PDT 
Added to the skipped list in 81514
Comment 2 Brady Eidson 2011-03-18 17:34:04 PDT 
Found a machine that could reproduce the issue that we could actually debug on.

The patch that changed this subtly delayed the favicon load asynchronously.  That was enough to throw off this test, which relies on the synchronous behavior of creating a webarchive.

There's currently no way for a web page to know if/when the icon has loaded.  To make this test work properly again, we'd have to add such a way.

In it's current state the test is invalid.  I'll chew on ways to make a valid version for a bit.
Comment 3 David Kilzer (:ddkilzer) 2011-03-20 21:18:45 PDT 
*** Bug 56663 has been marked as a duplicate of this bug. ***
Comment 4 Ryosuke Niwa 2013-05-22 15:31:32 PDT 
Now this test fails consistently.