RESOLVED FIXED 56684
Full Screen: disable keyboard access by default 
https://bugs.webkit.org/show_bug.cgi?id=56684
Summary Full Screen: disable keyboard access by default
Jer Noble
Reported Friday, March 18, 2011 10:38:06 PM UTC
WebKit should disallow full screen requests with keyboard access.
Attachments
Patch (14.83 KB, patch)
2011-03-26 00:59 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (14.86 KB, patch)
2011-03-26 01:12 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (14.86 KB, patch)
2011-03-26 11:27 PDT, Jer Noble 		mjs: review+
jer.noble: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 Friday, March 18, 2011 10:38:22 PM UTC
<rdar://problem/9156540>
Jer Noble
Comment 2 Saturday, March 26, 2011 8:59:19 AM UTC
Created attachment 87019 [details] Patch
Jer Noble
Comment 3 Saturday, March 26, 2011 9:12:24 AM UTC
Created attachment 87020 [details] Patch Fixed a compile warning due to an unused parameter.
WebKit Review Bot
Comment 4 Saturday, March 26, 2011 12:59:34 PM UTC
Attachment 87020 [details] did not build on mac: Build output: http://queues.webkit.org/results/8259049
Jer Noble
Comment 5 Saturday, March 26, 2011 7:27:19 PM UTC
Created attachment 87031 [details] Patch Fixed the mac EWS build errors.
Maciej Stachowiak
Comment 6 Sunday, March 27, 2011 2:22:09 AM UTC
Comment on attachment 87031 [details] Patch r=me
WebKit Review Bot
Comment 7 Sunday, March 27, 2011 10:24:12 PM UTC
Attachment 87031 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8262803
Jer Noble
Comment 8 Monday, March 28, 2011 5:28:16 AM UTC
Committed r82084: <http://trac.webkit.org/changeset/82084>
Sergio Villar Senin
Comment 9 Monday, March 28, 2011 10:36:33 AM UTC
(In reply to comment #8) > Committed r82084: <http://trac.webkit.org/changeset/82084> Several fullscreen tests started to fail on GTK+ bots after this change. I filed https://bugs.webkit.org/show_bug.cgi?id=57219 and skipped them while it isn't fixed.
Sergio Villar Senin
Comment 10 Monday, March 28, 2011 11:59:20 AM UTC
(In reply to comment #9) > (In reply to comment #8) > > Committed r82084: <http://trac.webkit.org/changeset/82084> > > Several fullscreen tests started to fail on GTK+ bots after this change. I filed https://bugs.webkit.org/show_bug.cgi?id=57219 and skipped them while it isn't fixed. Looks like we need to adapt some code in the chromeclient
mitz
Comment 11 Thursday, October 4, 2018 5:17:18 AM UTC
Comment on attachment 87031 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87031&action=review > Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm:976 > + SEL selector = @selector(webView:supportsFullScreenForElement:withKeyboard:); The method declaration in the delegate protocol was never changed to include the withKeyboard: argument.
Note You need to log in before you can comment on or make changes to this bug.