RESOLVED FIXED 56681
Web Inspector: expose object id as string, not JSON struct in the protocol. 
https://bugs.webkit.org/show_bug.cgi?id=56681
Summary Web Inspector: expose object id as string, not JSON struct in the protocol.
Pavel Feldman
Reported 2011-03-18 14:12:16 PDT
I'm brushing up the protocol and it seems like exposing ObjectId structure is not really necessary. I'm actually thinking of making all ids (network resources, dom nodes, javascript objects, call frames and page frames) simple strings.
Attachments
Patch (42.98 KB, patch)
2011-03-19 02:44 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-03-19 02:44:23 PDT
Created attachment 86257 [details] Patch
Ilya Tikhonovsky
Comment 2 2011-03-19 02:49:44 PDT
Comment on attachment 86257 [details] Patch lgtm
Yury Semikhatsky
Comment 3 2011-03-21 00:16:37 PDT
Comment on attachment 86257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86257&action=review > LayoutTests/http/tests/inspector/protocol-test.js:5 > + if (object instanceof Object) Consider renaming object to value. object sounds like an instance of Object while the parameter can take integer values. > Source/WebCore/inspector/InjectedScriptManager.cpp:83 > + bool success = parsedObjectId->asObject()->getNumber("injectedScriptId", &injectedScriptId); Now that objectId is an opaque string for the front-end we can switch to a more compact format, probably two numbers separated by a column.
Yury Semikhatsky
Comment 4 2011-03-21 00:16:59 PDT
Comment on attachment 86257 [details] Patch Please address the comments before landing.
Pavel Feldman
Comment 5 2011-03-21 00:42:57 PDT
Committed r81570: <http://trac.webkit.org/changeset/81570>
Note You need to log in before you can comment on or make changes to this bug.