Bug 56674 – Convert fake-drag into a dumpAsText test and remove 1s timeout

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

Convert fake-drag into a dumpAsText test and remove 1s timeout

[Tony Chang]

Created attachment 86205 [details]
Patch

[Tony Chang]

http://trac.webkit.org/changeset/10620 originally added this test.

[Tony Chang]

Also, this is one of the slowest editing tests.

[Eric Seidel (no email)]

Comment on attachment 86205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86205&action=review

OK.

> LayoutTests/editing/selection/fake-drag.html:23
> -    window.setTimeout(step7, 1);
> +    window.setTimeout(step7, 0);

This is 1ms, no?  Why make it 0?

[Eric Seidel (no email)]

Letting the authors of this test see this go by.

[Tony Chang]

(In reply to comment #4)
> (From update of attachment 86205 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86205&action=review
> 
> OK.
> 
> > LayoutTests/editing/selection/fake-drag.html:23
> > -    window.setTimeout(step7, 1);
> > +    window.setTimeout(step7, 0);
> 
> This is 1ms, no?  Why make it 0?

Since JS timers are 4ms, I think any value under 4 will behave the same.  I just wanted to make it explicit that we were running these as fast as possible.  Actually, we could probably just write this test without any of the setTimeouts.  Let me know if you think that would be clearer.

[Eric Seidel (no email)]

(In reply to comment #6)
> > This is 1ms, no?  Why make it 0?
> 
> Since JS timers are 4ms, I think any value under 4 will behave the same.

I think you're right.

>I just wanted to make it explicit that we were running these as fast as possible.  Actually, we could probably just write this test without any of the setTimeouts.  Let me know if you think that would be clearer.

Ideally we'd remove the setTimeouts, but I wouldn't worry about it.

[Tony Chang]

(In reply to comment #7)
> (In reply to comment #6)
> >I just wanted to make it explicit that we were running these as fast as possible.  Actually, we could probably just write this test without any of the setTimeouts.  Let me know if you think that would be clearer.
> 
> Ideally we'd remove the setTimeouts, but I wouldn't worry about it.

I tried this, but it turns out that we need setTimeouts or the editing delegate won't dump selection changes.  I'll just leave the timeouts in the test.

[Tony Chang]

Committed r81608: <http://trac.webkit.org/changeset/81608>