Bug 56656 – [chromium] add a build target to make a zip file with the inspector debug files

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

[chromium] add a build target to make a zip file with the inspector debug files

[Tony Chang]

Created attachment 86177 [details]
Patch

[Tony Chang]

Comment on attachment 86177 [details]
Patch

still working out some build issues and testing on windows

[Tony Chang]

Created attachment 86180 [details]
Patch

[Tony Chang]

On Windows, the target doesn't show up in chrome/chrome.sln (since we don't pull in the target), but it does show up in build/all.sln.  I think this is fine since the buildbots use all.sln.

This is chromium bug http://code.google.com/p/chromium/issues/detail?id=76553

[Tony Chang]

Created attachment 86392 [details]
Patch

[Tony Chang]

(In reply to comment #5)
> Created an attachment (id=86392) [details]
> Patch

Rebased the patch after bug 56661 landed.  Maybe yurys would like to review?

[Pavel Feldman]

Comment on attachment 86392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86392&action=review

I checked that it generates healthy front-end archive, which means that it is working :)

> Source/WebKit/chromium/WebKit.gyp:812
> +                'outputs': ['<(PRODUCT_DIR)/inspector_resources.zip'],

Could we name this devtools_resources.zip or devtools_frontend.zip instead?

> Source/WebKit/chromium/WebKit.gyp:813
> +                'action': ['python', '<@(_script_name)', '<@(_inspector_html)',

Could we generate zip with resources/inspector as a base directory? Otherwise, all entries in the zip file have resources/inspector prefixes.

[Tony Chang]

Created attachment 91303 [details]
Patch for landing

[Tony Chang]

Comment on attachment 86392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86392&action=review

>> Source/WebKit/chromium/WebKit.gyp:812
>> +                'outputs': ['<(PRODUCT_DIR)/inspector_resources.zip'],
> 
> Could we name this devtools_resources.zip or devtools_frontend.zip instead?

Renamed to devtools_frontend.zip

>> Source/WebKit/chromium/WebKit.gyp:813
>> +                'action': ['python', '<@(_script_name)', '<@(_inspector_html)',
> 
> Could we generate zip with resources/inspector as a base directory? Otherwise, all entries in the zip file have resources/inspector prefixes.

Done (removed kBaseDir in the python script).

[Tony Chang]

Committed r85071: <http://trac.webkit.org/changeset/85071>