Bug 56646 - Web Inspector: rename console agent events
Summary: Web Inspector: rename console agent events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-18 08:08 PDT by Ilya Tikhonovsky
Modified: 2011-03-18 13:21 PDT (History)
11 users (show)

See Also:

Attachments
[patch] initial version (7.45 KB, patch)
2011-03-18 08:13 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2011-03-18 08:08:47 PDT 
addConsoleMessage -> consoleMessage
updateConsoleMessageExpiredCount -> consoleMessageExpiredCountUpdate
updateConsoleMessageRepeatCount -> consoleMessageRepeatCountUpdate
Comment 1 Ilya Tikhonovsky 2011-03-18 08:13:29 PDT 
Created attachment 86166 [details]
[patch] initial version
Comment 2 WebKit Review Bot 2011-03-18 08:46:35 PDT 
Attachment 86166 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8198371
Comment 3 Ilya Tikhonovsky 2011-03-18 12:58:32 PDT 
landed as r81499
Comment 4 Pavel Feldman 2011-03-18 13:18:42 PDT 
Comment on attachment 86166 [details]
[patch] initial version

View in context: https://bugs.webkit.org/attachment.cgi?id=86166&action=review

> Source/WebCore/inspector/Inspector.idl:77
> +        [event] void consoleMessageExpiredCountUpdate(out unsigned long count);

I think these should have been:

"messageAdded",
"expiredCountUpdated",
"repeatCountUpdated"
Comment 5 Pavel Feldman 2011-03-18 13:21:43 PDT 
> "expiredCountUpdated",

In fact, this one should just be removed - it should become an out parameter in the "setConsoleMessagesEnabled". Which should be renamed to "enable" :)