WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
56635
Web Inspector: chromium: cleanup Web Inspector expectations.
https://bugs.webkit.org/show_bug.cgi?id=56635
Summary
Web Inspector: chromium: cleanup Web Inspector expectations.
Ilya Tikhonovsky
Reported
2011-03-18 01:56:15 PDT
Many Inspector tests are passing now but they still have expectations. I've removed unnecessary expectations and grouped the remainings.
Attachments
[patch] initial version
(6.48 KB, patch)
2011-03-18 01:57 PDT
,
Ilya Tikhonovsky
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2011-03-18 01:57:43 PDT
Created
attachment 86148
[details]
[patch] initial version
WebKit Review Bot
Comment 2
2011-03-18 02:00:06 PDT
Attachment 86148
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yury Semikhatsky
Comment 3
2011-03-18 02:01:16 PDT
Comment on
attachment 86148
[details]
[patch] initial version View in context:
https://bugs.webkit.org/attachment.cgi?id=86148&action=review
> LayoutTests/platform/chromium/test_expectations.txt:666 > +// Existing expectation above has been temporarily commented for this test. Please uncomment that one once
bug 56454
is fixed.
Remove this comment?
Pavel Feldman
Comment 4
2011-03-18 02:11:15 PDT
Comment on
attachment 86148
[details]
[patch] initial version View in context:
https://bugs.webkit.org/attachment.cgi?id=86148&action=review
Please fix the ChangeLog.
> LayoutTests/ChangeLog:6 > +
https://bugs.webkit.org/show_bug.cgi?id=56635
indent
> LayoutTests/ChangeLog:8 > + Many Inspector tests are passing now but they still have expectations.
You probably mean expected failures, not expectations.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug