Bug 56635 - Web Inspector: chromium: cleanup Web Inspector expectations.
Summary: Web Inspector: chromium: cleanup Web Inspector expectations.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-18 01:56 PDT by Ilya Tikhonovsky
Modified: 2011-03-18 08:14 PDT (History)
11 users (show)

See Also:

Attachments
[patch] initial version (6.48 KB, patch)
2011-03-18 01:57 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2011-03-18 01:56:15 PDT 
Many Inspector tests are passing now but they still have expectations.
I've removed unnecessary expectations and grouped the remainings.
Comment 1 Ilya Tikhonovsky 2011-03-18 01:57:43 PDT 
Created attachment 86148 [details]
[patch] initial version
Comment 2 WebKit Review Bot 2011-03-18 02:00:06 PDT 
Attachment 86148 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

LayoutTests/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yury Semikhatsky 2011-03-18 02:01:16 PDT 
Comment on attachment 86148 [details]
[patch] initial version

View in context: https://bugs.webkit.org/attachment.cgi?id=86148&action=review

> LayoutTests/platform/chromium/test_expectations.txt:666
> +// Existing expectation above has been temporarily commented for this test. Please uncomment that one once bug 56454 is fixed.

Remove this comment?
Comment 4 Pavel Feldman 2011-03-18 02:11:15 PDT 
Comment on attachment 86148 [details]
[patch] initial version

View in context: https://bugs.webkit.org/attachment.cgi?id=86148&action=review

Please fix the ChangeLog.

> LayoutTests/ChangeLog:6
> +	https://bugs.webkit.org/show_bug.cgi?id=56635

indent

> LayoutTests/ChangeLog:8
> +        Many Inspector tests are passing now but they still have expectations.

You probably mean expected failures, not expectations.