RESOLVED FIXED 56624
[CMAKE] Split JSC related configurations from WebCore/CMakeLists.txt 
https://bugs.webkit.org/show_bug.cgi?id=56624
Summary [CMAKE] Split JSC related configurations from WebCore/CMakeLists.txt
Ryuan Choi
Reported 2011-03-17 20:16:58 PDT
It's first step to support v8 on EFL build as an option.
Attachments
Patch (18.13 KB, patch)
2011-03-17 20:22 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (18.16 KB, patch)
2011-03-18 01:36 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (18.27 KB, patch)
2011-03-18 03:58 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-03-17 20:22:16 PDT
Created attachment 86132 [details] Patch
Patrick R. Gansterer
Comment 2 2011-03-18 00:13:58 PDT
Please give this file "*.cmake" extension. The different txt files is a ugly hack at the moment, which should be removed in the future.
Ryuan Choi
Comment 3 2011-03-18 01:36:24 PDT
Created attachment 86146 [details] Patch
Ryuan Choi
Comment 4 2011-03-18 01:39:05 PDT
(In reply to comment #2) > Please give this file "*.cmake" extension. The different txt files is a ugly hack at the moment, which should be removed in the future. Thanks, I changed CMakeListsJSC.txt to CMakeListsJSC.cmake.
Patrick R. Gansterer
Comment 5 2011-03-18 03:08:02 PDT
(In reply to comment #4) > (In reply to comment #2) > > Please give this file "*.cmake" extension. The different txt files is a ugly hack at the moment, which should be removed in the future. > > Thanks, I changed CMakeListsJSC.txt to CMakeListsJSC.cmake. Sorry for my short comment: I'd prefer UseJSC.cmake, corresponding to USE(JSC). IMHO the V8 part should be named UseV8.cmake. BTW: I think PlatformEFL.cmake and PlatformWinCE.cmake would be better compared to CMakeListsEFL.txt and CMakeListsWinCE.txt.
Ryuan Choi
Comment 6 2011-03-18 03:58:48 PDT
Created attachment 86154 [details] Patch
Ryuan Choi
Comment 7 2011-03-18 04:05:13 PDT
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > > Please give this file "*.cmake" extension. The different txt files is a ugly hack at the moment, which should be removed in the future. > > > > Thanks, I changed CMakeListsJSC.txt to CMakeListsJSC.cmake. > > Sorry for my short comment: I'd prefer UseJSC.cmake, corresponding to USE(JSC). > IMHO the V8 part should be named UseV8.cmake. No problem, I updated. > > BTW: I think PlatformEFL.cmake and PlatformWinCE.cmake would be better compared to CMakeListsEFL.txt and CMakeListsWinCE.txt. It looks no problem just for me. If other guys have no objection, I will prepare it.
Eric Seidel (no email)
Comment 8 2011-03-18 14:21:13 PDT
Comment on attachment 86154 [details] Patch rs=me.
WebKit Commit Bot
Comment 9 2011-03-18 14:52:10 PDT
The commit-queue encountered the following flaky tests while processing attachment 86154 [details]: webarchive/test-link-rel-icon.html bug 56663 (author: ddkilzer@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 2011-03-18 14:55:39 PDT
Comment on attachment 86154 [details] Patch Clearing flags on attachment: 86154 Committed r81515: <http://trac.webkit.org/changeset/81515>
WebKit Commit Bot
Comment 11 2011-03-18 14:55:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.