Bug 56612 - Web page shouldn't swallow alt-key combinations on Windows
Summary: Web page shouldn't swallow alt-key combinations on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Jeff Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-17 17:01 PDT by Jeff Miller
Modified: 2011-03-17 17:12 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.97 KB, patch)
2011-03-17 17:05 PDT, Jeff Miller
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Miller 2011-03-17 17:01:03 PDT
With the exception of Alt+Left Arrow and Alt+Right arrow to go back and forward (which seems to be a standard convention on Windows), web pages shouldn't swallow alt-key combinations, these should bubble up to the client.
Comment 1 Jeff Miller 2011-03-17 17:05:05 PDT
Created attachment 86118 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-03-17 17:09:17 PDT
Comment on attachment 86118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86118&action=review

What about Control-key combinations?

> Source/WebKit2/ChangeLog:9
> +        sure any alt-key combinations bubble up to the client.

I think you mean "any other alt-key combinations".
Comment 3 Jeff Miller 2011-03-17 17:10:52 PDT
(In reply to comment #2)
> (From update of attachment 86118 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86118&action=review
> 
> What about Control-key combinations?
> 
> > Source/WebKit2/ChangeLog:9
> > +        sure any alt-key combinations bubble up to the client.
> 
> I think you mean "any other alt-key combinations".

Yes I did, thanks.
Comment 4 Jeff Miller 2011-03-17 17:11:56 PDT
Committed r81416: <http://trac.webkit.org/changeset/81416>
Comment 5 Adam Roben (:aroben) 2011-03-17 17:12:33 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 86118 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=86118&action=review
> > 
> > What about Control-key combinations?

So what's the answer to this?