Bug 56599 - REGRESSION(81374, 81384): editing/deleting/5206311-1.html hits assertion on non-Mac platforms
: REGRESSION(81374, 81384): editing/deleting/5206311-1.html hits assertion on n...
Status: RESOLVED FIXED
: WebKit
HTML Editing
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
: LayoutTestFailure
:
:
  Show dependency treegraph
 
Reported: 2011-03-17 15:03 PST by
Modified: 2011-03-18 15:20 PST (History)


Attachments
Patch (2.46 KB, patch)
2011-03-17 22:27 PST, Ryosuke Niwa
no flags Review Patch | Details | Formatted Diff | Diff
Patch (5.53 KB, patch)
2011-03-17 22:39 PST, Ryosuke Niwa
no flags Review Patch | Details | Formatted Diff | Diff
updated Chromium test_expectations.txt (5.51 KB, patch)
2011-03-18 11:20 PST, Ryosuke Niwa
eric: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-03-17 15:03:22 PST
This assertion failure only occurs on non-Mac platforms.
------- Comment #1 From 2011-03-17 15:21:35 PST -------
Committed r81397: <http://trac.webkit.org/changeset/81397>
------- Comment #2 From 2011-03-17 22:07:22 PST -------
Now editing/deleting/5206311-2.html is asserting. It seems an earlier test is to blame.
------- Comment #3 From 2011-03-17 22:27:22 PST -------
Created an attachment (id=86135) [details]
Patch
------- Comment #4 From 2011-03-17 22:29:55 PST -------
(From update of attachment 86135 [details])
What about removing the test from the Skipped files?
------- Comment #5 From 2011-03-17 22:35:23 PST -------
(In reply to comment #4)
> (From update of attachment 86135 [details] [details])
> What about removing the test from the Skipped files?

Oops, let me do that.
------- Comment #6 From 2011-03-17 22:39:47 PST -------
Created an attachment (id=86136) [details]
Patch
------- Comment #7 From 2011-03-17 22:43:43 PST -------
Tried skipping the previous test (5168598.html) on Windows instead

Committed r81444: <http://trac.webkit.org/changeset/81444>
------- Comment #8 From 2011-03-17 22:58:26 PST -------
(In reply to comment #6)
> Created an attachment (id=86136) [details] [details]
> Patch

I'm not going to fix the purple EWSs as removing lines from Skipped / text_expectations.txt is bound to encounter some conflicts.
------- Comment #9 From 2011-03-17 23:56:58 PST -------
(In reply to comment #7)
> Tried skipping the previous test (5168598.html) on Windows instead
> 
> Committed r81444: <http://trac.webkit.org/changeset/81444>

This seems to have made the Windows XP bot stop asserting. So it seems 5168598.html is the problem.
------- Comment #10 From 2011-03-18 07:11:11 PST -------
The failure is now occurring on all DEBUG Chromium platforms (the faulty revision range is 81379:81398), I'm suppressing them now.
------- Comment #11 From 2011-03-18 09:58:53 PST -------
(In reply to comment #9)
> (In reply to comment #7)
> > Tried skipping the previous test (5168598.html) on Windows instead
> > 
> > Committed r81444: <http://trac.webkit.org/changeset/81444>
> 
> This seems to have made the Windows XP bot stop asserting. So it seems 5168598.html is the problem.

(In reply to comment #10)
> The failure is now occurring on all DEBUG Chromium platforms (the faulty revision range is 81379:81398), I'm suppressing them now.

It seems like there are some flakiness on the bot but it shouldn't affect the correctness of my patch.
------- Comment #12 From 2011-03-18 10:06:32 PST -------
(In reply to comment #9)
> This seems to have made the Windows XP bot stop asserting. So it seems 5168598.html is the problem.

There is some flakiness in the tests that adds hyper links.  Maybe there's some bug in the code that figures out visited-ness(?) of a URL.
------- Comment #13 From 2011-03-18 11:20:10 PST -------
Created an attachment (id=86182) [details]
updated Chromium test_expectations.txt
------- Comment #14 From 2011-03-18 14:21:51 PST -------
(From update of attachment 86182 [details])
OK.
------- Comment #15 From 2011-03-18 15:01:28 PST -------
Thanks for the review!
------- Comment #16 From 2011-03-18 15:20:18 PST -------
Committed r81518: <http://trac.webkit.org/changeset/81518>