Bug 56599 - REGRESSION(81374, 81384): editing/deleting/5206311-1.html hits assertion on non-Mac platforms
: REGRESSION(81374, 81384): editing/deleting/5206311-1.html hits assertion on n...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: HTML Editing
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Nobody
: LayoutTestFailure
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-17 15:03 PDT by Ryosuke Niwa
Modified: 2011-03-18 15:20 PDT (History)
12 users (show)

See Also:


Attachments
Patch (2.46 KB, patch)
2011-03-17 22:27 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch (5.53 KB, patch)
2011-03-17 22:39 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
updated Chromium test_expectations.txt (5.51 KB, patch)
2011-03-18 11:20 PDT, Ryosuke Niwa
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-03-17 15:03:22 PDT
This assertion failure only occurs on non-Mac platforms.
Comment 1 Ryosuke Niwa 2011-03-17 15:21:35 PDT
Committed r81397: <http://trac.webkit.org/changeset/81397>
Comment 2 Adam Roben (:aroben) 2011-03-17 22:07:22 PDT
Now editing/deleting/5206311-2.html is asserting. It seems an earlier test is to blame.
Comment 3 Ryosuke Niwa 2011-03-17 22:27:22 PDT
Created attachment 86135 [details]
Patch
Comment 4 Adam Roben (:aroben) 2011-03-17 22:29:55 PDT
Comment on attachment 86135 [details]
Patch

What about removing the test from the Skipped files?
Comment 5 Ryosuke Niwa 2011-03-17 22:35:23 PDT
(In reply to comment #4)
> (From update of attachment 86135 [details])
> What about removing the test from the Skipped files?

Oops, let me do that.
Comment 6 Ryosuke Niwa 2011-03-17 22:39:47 PDT
Created attachment 86136 [details]
Patch
Comment 7 Adam Roben (:aroben) 2011-03-17 22:43:43 PDT
Tried skipping the previous test (5168598.html) on Windows instead

Committed r81444: <http://trac.webkit.org/changeset/81444>
Comment 8 Ryosuke Niwa 2011-03-17 22:58:26 PDT
(In reply to comment #6)
> Created an attachment (id=86136) [details]
> Patch

I'm not going to fix the purple EWSs as removing lines from Skipped / text_expectations.txt is bound to encounter some conflicts.
Comment 9 Adam Roben (:aroben) 2011-03-17 23:56:58 PDT
(In reply to comment #7)
> Tried skipping the previous test (5168598.html) on Windows instead
> 
> Committed r81444: <http://trac.webkit.org/changeset/81444>

This seems to have made the Windows XP bot stop asserting. So it seems 5168598.html is the problem.
Comment 10 Alexander Pavlov (apavlov) 2011-03-18 07:11:11 PDT
The failure is now occurring on all DEBUG Chromium platforms (the faulty revision range is 81379:81398), I'm suppressing them now.
Comment 11 Ryosuke Niwa 2011-03-18 09:58:53 PDT
(In reply to comment #9)
> (In reply to comment #7)
> > Tried skipping the previous test (5168598.html) on Windows instead
> > 
> > Committed r81444: <http://trac.webkit.org/changeset/81444>
> 
> This seems to have made the Windows XP bot stop asserting. So it seems 5168598.html is the problem.

(In reply to comment #10)
> The failure is now occurring on all DEBUG Chromium platforms (the faulty revision range is 81379:81398), I'm suppressing them now.

It seems like there are some flakiness on the bot but it shouldn't affect the correctness of my patch.
Comment 12 Ryosuke Niwa 2011-03-18 10:06:32 PDT
(In reply to comment #9)
> This seems to have made the Windows XP bot stop asserting. So it seems 5168598.html is the problem.

There is some flakiness in the tests that adds hyper links.  Maybe there's some bug in the code that figures out visited-ness(?) of a URL.
Comment 13 Ryosuke Niwa 2011-03-18 11:20:10 PDT
Created attachment 86182 [details]
updated Chromium test_expectations.txt
Comment 14 Eric Seidel 2011-03-18 14:21:51 PDT
Comment on attachment 86182 [details]
updated Chromium test_expectations.txt

OK.
Comment 15 Ryosuke Niwa 2011-03-18 15:01:28 PDT
Thanks for the review!
Comment 16 Ryosuke Niwa 2011-03-18 15:20:18 PDT
Committed r81518: <http://trac.webkit.org/changeset/81518>