Bug 56595 - 1 Structure leaked beneath JSGlobalData::storeVPtrs()
Summary: 1 Structure leaked beneath JSGlobalData::storeVPtrs()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-17 14:42 PDT by Geoffrey Garen
Modified: 2011-03-18 11:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2011-03-17 14:43 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (1.72 KB, patch)
2011-03-17 16:39 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (6.04 KB, patch)
2011-03-17 22:47 PDT, Geoffrey Garen 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-03-17 14:42:47 PDT 
1 Structure leaked beneath JSGlobalData::storeVPtrs()
Comment 1 Geoffrey Garen 2011-03-17 14:43:50 PDT 
Created attachment 86096 [details]
Patch
Comment 2 Darin Adler 2011-03-17 14:55:22 PDT 
Comment on attachment 86096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86096&action=review

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:2641
>  			compatibilityVersion = "Xcode 3.1";
> -			developmentRegion = English;
>  			hasScannedForEncodings = 1;

Don’t land this part of the patch! Why are you using an older Xcode version?
Comment 3 Geoffrey Garen 2011-03-17 15:15:42 PDT 
Committed r81394: <http://trac.webkit.org/changeset/81394>
Comment 4 WebKit Review Bot 2011-03-17 15:23:17 PDT 
http://trac.webkit.org/changeset/81394 might have broken Windows Release (Build) and Windows Debug (Build)
Comment 5 Build Bot 2011-03-17 15:37:19 PDT 
Attachment 86096 [details] did not build on win:
Build output: http://queues.webkit.org/results/8192801
Comment 6 Geoffrey Garen 2011-03-17 16:38:10 PDT 
Looks like my last patch was not a complete fix.
Comment 7 Geoffrey Garen 2011-03-17 16:39:54 PDT 
Created attachment 86111 [details]
Patch
Comment 8 Geoffrey Garen 2011-03-17 16:47:03 PDT 
Committed r81410: <http://trac.webkit.org/changeset/81410>
Comment 9 Geoffrey Garen 2011-03-17 22:43:09 PDT 
Still not quite fixed!
Comment 10 Geoffrey Garen 2011-03-17 22:47:45 PDT 
Created attachment 86137 [details]
Patch
Comment 11 Geoffrey Garen 2011-03-18 09:56:45 PDT 
Committed r81483: <http://trac.webkit.org/changeset/81483>
Comment 12 WebKit Review Bot 2011-03-18 11:31:19 PDT 
http://trac.webkit.org/changeset/81483 might have broken GTK Linux 32-bit Release
The following tests are not passing:
fast/reflections/inline-crash.html