WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
56590
Rename setMarkedText to setMarkedTextAndSelectionWithin
https://bugs.webkit.org/show_bug.cgi?id=56590
Summary
Rename setMarkedText to setMarkedTextAndSelectionWithin
Ryosuke Niwa
Reported
2011-03-17 14:08:23 PDT
In the discussion on IRC, we came to conclusion that setMarkedText is a confusing function because it sets marked text and also selection within the marked text. This confusion resulted in an incorrect layout test change in
http://trac.webkit.org/changeset/80064
. We should rename this function to setMarkedTextAndSelectionWithin so that we don't make similar mistakes in the future.
Attachments
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2011-03-17 14:32:28 PDT
This bug is about a TextInputController method that's exposing setMarkedText:selectedRange: AppKit method.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug