Bug 56589 - WebKit2: Cancelling full screen early leaves full screen window up.
Summary: WebKit2: Cancelling full screen early leaves full screen window up.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-03-17 14:03 PDT by Jer Noble
Modified: 2011-03-25 08:52 PDT (History)
0 users

See Also:

Attachments
Patch (3.76 KB, patch)
2011-03-17 14:11 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (4.84 KB, patch)
2011-03-24 14:09 PDT, Jer Noble 		mjs: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-03-17 14:03:44 PDT 
WebKit2: Cancelling full screen early leaves full screen window up.
Comment 1 Jer Noble 2011-03-17 14:11:11 PDT 
Created attachment 86092 [details]
Patch
Comment 2 Jer Noble 2011-03-17 14:24:01 PDT 
<rdar://problem/9150807>
Comment 3 Eric Seidel (no email) 2011-03-18 14:23:22 PDT 
Comment on attachment 86092 [details]
Patch

Seems reasonable.  Can this be tested?
Comment 4 Jer Noble 2011-03-18 15:16:34 PDT 
(In reply to comment #3)
> (From update of attachment 86092 [details])
> Seems reasonable.  Can this be tested?

Depends.  If you mean, can the testing be automated, unfortunately no.  The WebKitTestRunner doesn't support the new full screen APIs yet.

But it can be manually tested by enabling WebKit's full screen mode in Safari:

> defaults write com.apple.Safari WebKitFullScreenEnabled -bool true
Comment 5 Maciej Stachowiak 2011-03-23 18:01:26 PDT 
Comment on attachment 86092 [details]
Patch

r=me , please add a ChangeLog comment explaining why an automated test is not possible at this time.
Comment 6 Jer Noble 2011-03-24 14:09:28 PDT 
Created attachment 86834 [details]
Patch

When prepping this patch for checkin, I realized a piece was in a separate commit, and never was reviewed.  Re-uploading a patch with changes to WebFullScreenManagerMac.mm attached.
Comment 7 Maciej Stachowiak 2011-03-24 14:29:07 PDT 
Comment on attachment 86834 [details]
Patch

r=me
Comment 8 Jer Noble 2011-03-24 14:46:08 PDT 
Committed r81901: <http://trac.webkit.org/changeset/81901>