RESOLVED FIXED 56582
Update CSP directive parser to match spec 
https://bugs.webkit.org/show_bug.cgi?id=56582
Summary Update CSP directive parser to match spec
Adam Barth
Reported 2011-03-17 12:58:57 PDT
Update CSP directive parser to match spec
Attachments
Patch (8.50 KB, patch)
2011-03-17 13:01 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-03-17 13:01:12 PDT
Created attachment 86084 [details] Patch
Eric Seidel (no email)
Comment 2 2011-03-17 16:19:39 PDT
Comment on attachment 86084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86084&action=review Looks reasonable. > Source/WebCore/page/ContentSecurityPolicy.cpp:42 > +static void advanceUntil(const UChar*& pos, const UChar* end, UChar delimiter) I take it you don't need to return success vs. failure here?
Adam Barth
Comment 3 2011-03-17 16:20:45 PDT
(In reply to comment #2) > (From update of attachment 86084 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86084&action=review > > Looks reasonable. > > > Source/WebCore/page/ContentSecurityPolicy.cpp:42 > > +static void advanceUntil(const UChar*& pos, const UChar* end, UChar delimiter) > > I take it you don't need to return success vs. failure here? Nope. It just eats everything until ";" or END, so there can't be an error.
WebKit Commit Bot
Comment 4 2011-03-17 18:58:35 PDT
Comment on attachment 86084 [details] Patch Clearing flags on attachment: 86084 Committed r81425: <http://trac.webkit.org/changeset/81425>
WebKit Commit Bot
Comment 5 2011-03-17 18:58:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.