Bug 56582 - Update CSP directive parser to match spec
Summary: Update CSP directive parser to match spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 53572
  Show dependency treegraph
 
Reported: 2011-03-17 12:58 PDT by Adam Barth
Modified: 2011-03-17 18:58 PDT (History)
1 user (show)

See Also:


Attachments
Patch (8.50 KB, patch)
2011-03-17 13:01 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-17 12:58:57 PDT
Update CSP directive parser to match spec
Comment 1 Adam Barth 2011-03-17 13:01:12 PDT
Created attachment 86084 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-03-17 16:19:39 PDT
Comment on attachment 86084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86084&action=review

Looks reasonable.

> Source/WebCore/page/ContentSecurityPolicy.cpp:42
> +static void advanceUntil(const UChar*& pos, const UChar* end, UChar delimiter)

I take it you don't need to return success vs. failure here?
Comment 3 Adam Barth 2011-03-17 16:20:45 PDT
(In reply to comment #2)
> (From update of attachment 86084 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86084&action=review
> 
> Looks reasonable.
> 
> > Source/WebCore/page/ContentSecurityPolicy.cpp:42
> > +static void advanceUntil(const UChar*& pos, const UChar* end, UChar delimiter)
> 
> I take it you don't need to return success vs. failure here?

Nope.  It just eats everything until ";" or END, so there can't be an error.
Comment 4 WebKit Commit Bot 2011-03-17 18:58:35 PDT
Comment on attachment 86084 [details]
Patch

Clearing flags on attachment: 86084

Committed r81425: <http://trac.webkit.org/changeset/81425>
Comment 5 WebKit Commit Bot 2011-03-17 18:58:40 PDT
All reviewed patches have been landed.  Closing bug.