Bug 56574 - Dealloc'ing a WKView can leave a stale reference to it in NSWindow
Summary: Dealloc'ing a WKView can leave a stale reference to it in NSWindow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: John Sullivan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-17 10:49 PDT by John Sullivan
Modified: 2011-03-17 11:41 PDT (History)
0 users

See Also:

Attachments
Patch to clear growBoxOwner at the appropriate time. (1.70 KB, patch)
2011-03-17 10:53 PDT, John Sullivan 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Sullivan 2011-03-17 10:49:19 PDT 
WKView is setting itself as the window's _growBoxOwner in an override of _updateGrowBoxForWindowFrameChange, but isn't clearing it at any point. NSWindow doesn't retain/release its growBoxOwner, so this can lead to a bad object ref in NSWindow that results in crashes.
Comment 1 John Sullivan 2011-03-17 10:53:29 PDT 
Created attachment 86069 [details]
Patch to clear growBoxOwner at the appropriate time.
Comment 2 John Sullivan 2011-03-17 11:41:43 PDT 
Committed in http://trac.webkit.org/changeset/81372