Bug 56562 - Web Inspector: add types markup to the IDL, remove Value types from the protocol.
Summary: Web Inspector: add types markup to the IDL, remove Value types from the proto...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-17 08:33 PDT by Pavel Feldman
Modified: 2011-03-17 11:10 PDT (History)
11 users (show)

See Also:

Attachments
Patch (54.26 KB, patch)
2011-03-17 08:56 PDT, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-03-17 08:33:51 PDT 
We should not use Value in the protocol (we know exact type - Object / Array / primitive that we use).
Comment 1 Pavel Feldman 2011-03-17 08:56:00 PDT 
Created attachment 86060 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-17 08:58:46 PDT 
Attachment 86060 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InjectedScript.cpp:207:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/inspector/InspectorDebuggerAgent.h:90:  The parameter name "error" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDebuggerAgent.h:101:  The parameter name "error" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorApplicationCacheAgent.h:63:  The parameter name "error" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Pavel Feldman 2011-03-17 11:10:39 PDT 
Committed r81368: <http://trac.webkit.org/changeset/81368>