RESOLVED FIXED 56562
Web Inspector: add types markup to the IDL, remove Value types from the protocol. 
https://bugs.webkit.org/show_bug.cgi?id=56562
Summary Web Inspector: add types markup to the IDL, remove Value types from the proto...
Pavel Feldman
Reported 2011-03-17 08:33:51 PDT
We should not use Value in the protocol (we know exact type - Object / Array / primitive that we use).
Attachments
Patch (54.26 KB, patch)
2011-03-17 08:56 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-03-17 08:56:00 PDT
Created attachment 86060 [details] Patch
WebKit Review Bot
Comment 2 2011-03-17 08:58:46 PDT
Attachment 86060 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InjectedScript.cpp:207: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Source/WebCore/inspector/InspectorDebuggerAgent.h:90: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/inspector/InspectorDebuggerAgent.h:101: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/inspector/InspectorApplicationCacheAgent.h:63: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Pavel Feldman
Comment 3 2011-03-17 11:10:39 PDT
Committed r81368: <http://trac.webkit.org/changeset/81368>
Note You need to log in before you can comment on or make changes to this bug.