WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
56558
Web Inspector: add support for formating source files in debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=56558
Summary
Web Inspector: add support for formating source files in debugger presentatio...
Pavel Podivilov
Reported
2011-03-17 06:38:29 PDT
Web Inspector: add support for formating source files in debugger presentation model. This is still behind the flag.
Attachments
Patch.
(16.18 KB, patch)
2011-03-17 06:39 PDT
,
Pavel Podivilov
no flags
Details
Formatted Diff
Diff
Patch.
(19.59 KB, patch)
2011-03-21 12:02 PDT
,
Pavel Podivilov
yurys
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Pavel Podivilov
Comment 1
2011-03-17 06:39:08 PDT
Created
attachment 86052
[details]
Patch.
Pavel Podivilov
Comment 2
2011-03-21 12:02:23 PDT
Created
attachment 86348
[details]
Patch.
Yury Semikhatsky
Comment 3
2011-03-22 09:23:25 PDT
Comment on
attachment 86348
[details]
Patch. View in context:
https://bugs.webkit.org/attachment.cgi?id=86348&action=review
> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:164 > + this._refreshBreakpoints();
All breakpoints are already updated by _addScript, why do you need this call?
Pavel Podivilov
Comment 4
2011-03-23 08:05:22 PDT
Committed
r81774
: <
http://trac.webkit.org/changeset/81774
>
Pavel Podivilov
Comment 5
2011-03-23 08:06:23 PDT
(In reply to
comment #3
)
> (From update of
attachment 86348
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=86348&action=review
> > > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:164 > > + this._refreshBreakpoints(); > > All breakpoints are already updated by _addScript, why do you need this call?
Removed call to _refreshBreakpoints from _addScript to add all breakpoints at once.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug