Bug 56549 - Non-ASCII characters in XMLTreeViewer.{cpp,h}
Summary: Non-ASCII characters in XMLTreeViewer.{cpp,h}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Yuta Kitamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-17 00:45 PDT by Yuta Kitamura
Modified: 2011-03-17 01:51 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-03-17 00:45:57 PDT
The license statement in WebCore/xml/XMLTreeViewer.{cpp,h} contains non-ASCII characters (quotes surrounding "AS IS").

These characters caused a compile error on my local Windows build environment:

> ..\xml\XMLTreeViewer.cpp : error C2220: warning treated as error - no 'object' file generated
> ..\xml\XMLTreeViewer.cpp : warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss

Code page 932 means Japanese locale; Visual Studio seems to complain about these characters if the system locale is set to Japanese.

These source files were added in r79861 (bug 13807).

I will work on a patch for this. Since this is a build fix and the fix is simple, I will commit it as unreviewed.
Comment 1 Yuta Kitamura 2011-03-17 00:51:53 PDT
Committed r81335: <http://trac.webkit.org/changeset/81335>
Comment 2 WebKit Review Bot 2011-03-17 01:51:15 PDT
http://trac.webkit.org/changeset/81335 might have broken SnowLeopard Intel Release (WebKit2 Tests)
The following tests are not passing:
http/tests/inspector/resource-har-conversion.html