Bug 56511 - Invalidate all NPObjects for a plug-in when that plug-in is destroyed
Summary: Invalidate all NPObjects for a plug-in when that plug-in is destroyed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-16 17:56 PDT by Anders Carlsson
Modified: 2011-03-17 12:42 PDT (History)
3 users (show)

See Also:


Attachments
Patch (12.10 KB, patch)
2011-03-16 18:01 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (12.08 KB, patch)
2011-03-16 18:11 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (14.75 KB, patch)
2011-03-16 18:35 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (14.75 KB, patch)
2011-03-16 19:00 PDT, Anders Carlsson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-03-16 17:56:02 PDT
Invalidate all NPObjects for a plug-in when that plug-in is destroyed
Comment 1 Anders Carlsson 2011-03-16 18:01:35 PDT
Created attachment 86013 [details]
Patch
Comment 2 Anders Carlsson 2011-03-16 18:11:19 PDT
Created attachment 86015 [details]
Patch
Comment 3 Anders Carlsson 2011-03-16 18:27:25 PDT
Comment on attachment 86015 [details]
Patch

This patch is incorrect.
Comment 4 Anders Carlsson 2011-03-16 18:35:47 PDT
Created attachment 86016 [details]
Patch
Comment 5 Anders Carlsson 2011-03-16 19:00:24 PDT
Created attachment 86019 [details]
Patch
Comment 6 Darin Adler 2011-03-16 19:49:20 PDT
Comment on attachment 86019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86019&action=review

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:86
> +        // Get the plug-in so we can pass it to removePluginControllerProxy. The pointer is only
> +        // used as an identifier so it's OK to just get a weak reference.

Aliasing can happen even when a pointer is just used as an identifier. In these cases I guess it’s OK because there’s no chance a new plug-in will be allocated before the remove call is made.
Comment 7 Anders Carlsson 2011-03-17 11:28:57 PDT
Committed r81370: <http://trac.webkit.org/changeset/81370>
Comment 8 WebKit Review Bot 2011-03-17 12:42:19 PDT
http://trac.webkit.org/changeset/81370 might have broken Leopard Intel Release (Tests)