Bug 56477 - WebKit2: Sometimes Command-[ opens a new tab and loads the back page in it
Summary: WebKit2: Sometimes Command-[ opens a new tab and loads the back page in it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P1 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-03-16 12:21 PDT by Alexey Proskuryakov
Modified: 2011-03-16 13:13 PDT (History)
1 user (show)

See Also:


Attachments
proposed fix (1.59 KB, patch)
2011-03-16 12:26 PDT, Alexey Proskuryakov
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-03-16 12:21:00 PDT
Sometimes pressing Command-[ opens a new tab and navigates to the last item in the current tab’s back list in that new tab.

<rdar://problem/8806664>
Comment 1 Alexey Proskuryakov 2011-03-16 12:26:28 PDT
Created attachment 85955 [details]
proposed fix
Comment 2 Alexey Proskuryakov 2011-03-16 12:27:22 PDT
As far as I can tell, there is no need to reset the current event back (or to nil).
Comment 3 mitz 2011-03-16 12:40:03 PDT
Comment on attachment 85955 [details]
proposed fix

Can we use the NSApp global instead of messaging NSApplication twice?
Comment 4 Alexey Proskuryakov 2011-03-16 12:49:54 PDT
I guess we can.

Committed <http://trac.webkit.org/changeset/81269>.
Comment 5 Darin Adler 2011-03-16 13:13:06 PDT
Don’t we want to restore the old current event on return?