Bug 56450 - Need to do an experiment to make sure that reftests don't cause any issues on all buildbots
Summary: Need to do an experiment to make sure that reftests don't cause any issues on...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 36065
  Show dependency treegraph
 
Reported: 2011-03-15 23:18 PDT by Hayato Ito
Modified: 2011-03-21 22:00 PDT (History)
3 users (show)

See Also:


Attachments
the-first-reftest (1.62 KB, patch)
2011-03-15 23:20 PDT, Hayato Ito
no flags Details | Formatted Diff | Diff
move-to-harness (1.65 KB, patch)
2011-03-20 21:04 PDT, Hayato Ito
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2011-03-15 23:18:23 PDT
I'll submit the first reftest after all necessary changes are landed.
Comment 1 Hayato Ito 2011-03-15 23:20:14 PDT
Created attachment 85913 [details]
the-first-reftest
Comment 2 Hayato Ito 2011-03-15 23:21:15 PDT
I've checked it as 'r?', but I won't submit this patch soon until all necessary changes are landed.
Comment 3 Eric Seidel (no email) 2011-03-17 04:29:57 PDT
Comment on attachment 85913 [details]
the-first-reftest

What identifies this as a reftest?  expected.html I assume?
Comment 4 Hayato Ito 2011-03-17 04:39:39 PDT
Yeah, we use a naming convention to identify.

Please see a master bug to know how and why:
  https://bugs.webkit.org/show_bug.cgi?id=36065

And the Wiki page I started to write is here:
  http://trac.webkit.org/wiki/Writing%20Reftests

(In reply to comment #3)
> (From update of attachment 85913 [details])
> What identifies this as a reftest?  expected.html I assume?
Comment 5 Eric Seidel (no email) 2011-03-18 14:34:17 PDT
Comment on attachment 85913 [details]
the-first-reftest

Seems this should go into the harness directory (which is about testing DRT/RWT) since this test doesn't really add much to our CSS testing.
Comment 6 Hayato Ito 2011-03-18 19:17:02 PDT
This is an experiment reftest, so the test itself doesn't matter. If you think this test doesn't add much to our css testing, I am happy to revert it after we confirm all buildbots are happy with this reftest.

We decided to use LayoutTest directory to where '-expected.html' is added as other existing LayoutTests do. So '-expected.html' must go into LayoutTests directory to do an experiment.

(In reply to comment #5)
> (From update of attachment 85913 [details])
> Seems this should go into the harness directory (which is about testing DRT/RWT) since this test doesn't really add much to our CSS testing.
Comment 7 Ojan Vafai 2011-03-20 15:24:29 PDT
I think Eric was just saying that the test should go in fast/harness instead of fast/css.
Comment 8 Hayato Ito 2011-03-20 21:04:14 PDT
Created attachment 86293 [details]
move-to-harness
Comment 9 Hayato Ito 2011-03-20 21:08:29 PDT
Hi Ojan, thank you for clarifying that.

Although I am not 100% sure what the purpose of the  'fast/harness' directory is, I've moved the test to 'fast/harness' directory.

Could you review it?

(In reply to comment #7)
> I think Eric was just saying that the test should go in fast/harness instead of fast/css.
Comment 10 Hayato Ito 2011-03-21 22:00:03 PDT
Committed r81644: <http://trac.webkit.org/changeset/81644>