Bug 56447 - Some conservative root gathering cleanup
Summary: Some conservative root gathering cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-15 22:14 PDT by Geoffrey Garen
Modified: 2011-03-16 12:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (15.00 KB, patch)
2011-03-15 22:43 PDT, Geoffrey Garen 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-03-15 22:14:06 PDT 
Some conservative root gathering cleanup
Comment 1 Geoffrey Garen 2011-03-15 22:43:07 PDT 
Created attachment 85910 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-15 22:45:56 PDT 
Attachment 85910 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/runtime/MarkStack.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2011-03-16 11:35:54 PDT 
Committed r81262: <http://trac.webkit.org/changeset/81262>
Comment 4 WebKit Review Bot 2011-03-16 12:27:53 PDT 
http://trac.webkit.org/changeset/81262 might have broken Windows 7 Release (Tests)
The following tests are not passing:
plugins/refcount-leaks.html