Bug 56445 – Logic error in -[WebHTMLView close]

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jeff Johnson]

The following code is in -[WebHTMLView close]:

    [_private clear];

    Page* page = core([self _webView]);
    if (page)
        page->dragController()->setDraggingImageURL(KURL());

However, -[WebHTMLViewPrivate clear] has this code:

    dataSource = nil;

And -[WebHTMLView _webView] is as follows:

- (WebView *)_webView
{
    return [_private->dataSource _webView];
}

Thus, the call to [self _webView] always returns nil after [_private clear], and page will always be nil too.

The "page" code in-[WebHTMLView close] was introduced in <https://trac.webkit.org/changeset/19104>. I'd say it's hard to image that this section of code was ever tested.

I discovered this logic error while investigating https://bugs.webkit.org/show_bug.cgi?id=26667

[Alexey Proskuryakov]

Would you be willing to make a patch removing the dead code?

[Jeff Johnson]

I suppose. We know it hasn't done anything for 4 years. But shouldn't someone figure out what it was supposed to do in the first place? ;-)

[Alexey Proskuryakov]

That would certainly be nice, but it's not really a prerequisite for removing old dead code.

[Jeff Johnson]

Created attachment 86023 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 86023 [details]
Patch

Also marking cq+ for commit queue to land this patch.

[WebKit Commit Bot]

Comment on attachment 86023 [details]
Patch

Clearing flags on attachment: 86023

Committed r81330: <http://trac.webkit.org/changeset/81330>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.