Bug 56444 - Add support for Sun Studio 12 compiler on Solaris
Summary: Add support for Sun Studio 12 compiler on Solaris
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-15 20:59 PDT by Ben Taylor
Modified: 2011-03-17 13:07 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler (1.11 KB, patch)
2011-03-15 21:04 PDT, Ben Taylor
ap: review+
ap: commit-queue+
Details | Formatted Diff | Diff
Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler (1.16 KB, patch)
2011-03-16 11:37 PDT, Ben Taylor
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Taylor 2011-03-15 20:59:17 PDT
Adding support for Sun Studio 12 compiler on Solaris 10. This is a derivitive of the first of 16 patches from the bug in https://bugs.webkit.org/show_bug.cgi?id=24932.  The other parts of the original patch have already been folded and transformed since the origination of this patch.
Comment 1 Ben Taylor 2011-03-15 21:04:49 PDT
Created attachment 85903 [details]
Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler

This patch is what is remaining uncommited to the webkit source, from the patch 1 of 16 from bug https://bugs.webkit.org/show_bug.cgi?24932 originally done by Thiago Macierira.  It simply adds support for the Sun Studio Compiler.
Comment 2 Alexey Proskuryakov 2011-03-16 11:06:07 PDT
Comment on attachment 85903 [details]
Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler

View in context: https://bugs.webkit.org/attachment.cgi?id=85903&action=review

> Source/JavaScriptCore/ChangeLog:6
> +        Add a COMPILER(SUNCC) define for Sun Studio 12. Streamlined patch
> +        1 of 16 originally from https://bugs.webkit.org/show_bug.cgi?id=24932

You need to provide an URL of this bug, not some other one.

Doesn't matter all that much in this particular case, because there isn't a lot to look for in this bug.
Comment 3 Ben Taylor 2011-03-16 11:08:42 PDT
Happy to resubmit with a corrected ChangeLog.  Let me know.
Comment 4 Ben Taylor 2011-03-16 11:37:29 PDT
Created attachment 85949 [details]
Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler

Updated ChangeLog to correctly identify this bug and to also identify the derivation of the patch.
Comment 5 Alexey Proskuryakov 2011-03-17 10:52:58 PDT
Comment on attachment 85949 [details]
Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler

Due to an e-mail exchange, I'm assuming that you intended to mark this for review.
Comment 6 WebKit Commit Bot 2011-03-17 13:04:58 PDT
The commit-queue encountered the following flaky tests while processing attachment 85949 [details]:

http/tests/inspector/network/network-size.html bug 56581 (author: pfeldman@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2011-03-17 13:07:30 PDT
Comment on attachment 85949 [details]
Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler

Clearing flags on attachment: 85949

Committed r81379: <http://trac.webkit.org/changeset/81379>
Comment 8 WebKit Commit Bot 2011-03-17 13:07:35 PDT
All reviewed patches have been landed.  Closing bug.